Rewrite Get-FileHash on C# #2731

Activity

1. rkeithhill commented on Nov 20, 2016

   

   Keith Hill (rkeithhill)

   on Nov 20, 2016

   Collaborator

   More actions

   BTW, any chance we could add a Get-Hash command as well that would operate on strings instead of files? This comes in handy. See the PSCX impl for Get-Hash as an example. Of course, if I were writing this command from scratch today, I would default to SHA256 instead of MD5. :-)

   👍React with 👍1Reacted by Daniel
2. Steve Lee (SteveL-MSFT)

   added

   WG-Cmdletsgeneral cmdlet issuesgeneral cmdlet issues

   Up-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsUp-for-grabs issues are not high priorities, and may be opportunities for external contributors

   on Nov 20, 2016
3. iSazonov commented on Nov 20, 2016

   

   Ilya (iSazonov)

   on Nov 20, 2016

   CollaboratorAuthor

   More actions

   default to SHA256 instead of MD5

   I agree but
   Is this a breaking change or not?
4. rkeithhill commented on Nov 20, 2016

   

   Keith Hill (rkeithhill)

   on Nov 20, 2016

   Last edited by rkeithhill

   Collaborator

   More actions

   Get-Hash doesn't exist right now so no worries about a breaking change. And the default Algorithm for Get-FileHash is SHA256. My only point is that it would be nice to have a cmdlet that hashes strings (in addition to the existing cmdlet that operates on files).

   It is a drag that if you want to hash a string, you have to write it to a file. OK that is not entirely true, you can hash a string directly but not many folks will figure this out:

   Get-FileHash -InputStream ([System.IO.MemoryStream]::new([System.Text.Encoding]::ASCII.GetBytes("open sesame")))
5. iSazonov commented on Nov 21, 2016

   

   Ilya (iSazonov)

   on Nov 21, 2016

   CollaboratorAuthor

   More actions

   Keith Hill (@rkeithhill) Great idea!
   So maybe make new Get-Hash cmdlet with support file and string sources and make Get-FileHash as wrapper for it?

   👍React with 👍2Reacted by Keith Hill and Daniel
6. iSazonov commented on Jan 19, 2017

   

   Ilya (iSazonov)

   on Jan 19, 2017

   CollaboratorAuthor

   More actions

   PowerShellTeam I started working on this, please assign me.
7. Jason Shirk (lzybkr)

   assigned

   Ilya (iSazonov)

   on Jan 19, 2017
8. Jason Shirk (lzybkr)

   removed

   Up-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsUp-for-grabs issues are not high priorities, and may be opportunities for external contributors

   on Jan 19, 2017
9. Jason Shirk (lzybkr)

   closed this as completedin #3024on Feb 4, 2017
10. Ilya (iSazonov)

    added

    Resolution-FixedThe issue is fixed.The issue is fixed.

    on Mar 8, 2017