Repository navigation
Review all if/def and Unix specific code after moving to .NET Core 2.0 #3565
Description
PowerShell Core is moving to .NET Core 2.0 with PR #3556. Once that PR is merged, we need to review all if/def and Unix specific code to:
- Clean up the code
- Make sure the code make sense and is not a temporary hack
An Example (Please remove when fixed)
Platform.InternalGetFolderPath in src/System.Management.Automation/CoreCLR/CorePsPlatform.cs has the following code:
case System.Environment.SpecialFolder.ProgramFiles:
folderPath = "/bin";
if (!System.IO.Directory.Exists(folderPath)) { folderPath = null; }
break;
case System.Environment.SpecialFolder.ProgramFilesX86:
folderPath = "/usr/bin";
if (!System.IO.Directory.Exists(folderPath)) { folderPath = null; }
break;
case System.Environment.SpecialFolder.System:
case System.Environment.SpecialFolder.SystemX86:
folderPath = "/sbin";
if (!System.IO.Directory.Exists(folderPath)) { folderPath = null; }
break;
It use /bin for ProgramFiles, /usr/bin for ProgramFilesX86 and /sbin for System and SystemX86. It's not clear if this is appropriate, so code like this should be reviewed.
Activity
iSazonov commentedon Apr 14, 2017
Dongbo Wang (@daxian-dbw) If this does not require a lot of time please create a sln file - without it IntelliSense does not work in VS Code (after json files was removed) properly.
daxian-dbw commentedon Apr 14, 2017
Ilya (@iSazonov) IntelliSense doesn't work for you? It works for me in VS Code after moving to
.csprojfile. Just runStart-PSBuild -publish, then open the.csprojfile in VS Code, and if you see a prompt on top of VS Code asking to restore, just clickClose, and things like reference resolution and IntelliSense should just work.I thought creating a
slnfile would be just as simple as openingpowershell-win-core.csprojin VS2017 and then saving a solution file, but it turned out the.csprojdoesn't work properly within VS2017. I haven't got the chance to figure out why and fix it.jeffbi commentedon Apr 15, 2017
Dongbo Wang (@daxian-dbw), Ilya (@iSazonov) IntelliSense doesn't work for me either. I tried following the steps above, but no joy.
iSazonov commentedon Apr 15, 2017
As mentioned in #3356 there is a limitation dotnet/vscode-csharp#1156
So we need sln file in repo root folder.
I suggest to continue the discussion in #3356.
iSazonov commentedon Apr 27, 2017
Code for review https://github.com/PowerShell/PowerShell/pull/3224/files#r103523572
andyleejordan commentedon Aug 7, 2017
These hacks are finally being cleaned up? Huzzah!
iSazonov commentedon Nov 26, 2018
I created 3 PRs to address
#if CORECLR.There are still 75 places left but they are too complicated for me. Leave them to MSFT team.
/cc Steve Lee (@SteveL-MSFT)
microsoft-github-policy-service commentedon Nov 16, 2023
This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.
microsoft-github-policy-service commentedon Nov 16, 2023
This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.
microsoft-github-policy-service commentedon Nov 16, 2023
This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.
microsoft-github-policy-service commentedon Nov 23, 2023
This issue has been marked as "No Activity" as there has been no activity for 6 months. It has been closed for housekeeping purposes.