You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Implement completion for package references in csproj files #1156
.NET Command Line Tools (1.0.0-rc4-004706)
Product Information:
Version: 1.0.0-rc4-004706
Commit SHA-1 hash: e38bc4950c
Runtime Environment:
OS Name: Mac OS X
OS Version: 10.11
OS Platform: Darwin
RID: osx.10.11-x64
Base Path: /usr/local/share/dotnet/sdk/1.0.0-rc4-004706
VS Code version: 1.8.1 ee428b0eead68bf0fb99ab5fdc4439be227b6281
C# Extension version: 1.6.2
Steps to reproduce
Edit a netcore csproj
Expected behavior
Intellisense when trying to get nuget package names and versions. This is currently possible in project.json. Editing this file manually without intellisense is a bit painful.
Hi,
I'd be willing to give this a shot. I think this was/is a killer feature and I'm already starting to miss it! ;)
Are you planning on merging PR #224? In that case I should make the implementation for csproj somehow fit into what was there for project.json. Otherwise I'd use the project.json implementation as a template for csproj wherever it makes sense.
I'd start by raising the PR asap so you can easily follow up on progress. Since you tagged this issue as Backlog, should I target master or future with my PR?
Let me know your plans regarding #224 so I can compile the task list for my PR.
Cheers,
Christoph
Reacted by Vlad Kovalev, Ben Collins, Christian Horsdal, Rasmus Lilja and Bryan Hitchcock
Indeed editing without the intellisense is a bit of a pain so I've been using the dotnet cli to manipulate nuget packages. Though I would use this should it be completed. Good luck!
It's not part of OmniSharp, but I finally bit the bullet and wrote an extension to provide basic completion for PackageReference elements (package Ids and versions). I'm planning to eventually build out a full MSBuild language service behind it but it's probably good enough now for the most common use-case (packages from nuget.org - custom package sources from NuGet.config will be added in a later release). The NuGet v3 API is a little slow (but not infuriatingly so). Hopefully they'll improve it over time.
BTW, I'm happy to contribute this functionality back to OmniSharp if it makes sense to do so.
Reacted by Vlad Kovalev, Kun Ren, Pekka Savolainen, Sean Lynch, Eugene Bekker, Will 保哥, Bryan Hitchcock and arrebole
The current changelog for C# extension reads "Known Issues in 1.12.0...There currently is no completion support for package references in csproj files. (#1156)"
Might be a good idea to add a link to @tintoy 's extension to tide people over in the interim. Or just simply adopt that extension wholesale as the official support.
That's a very good idea (and thanks for bumping this issue to the top of my stack 😄).
@tintoy: I'd definitely work with you to contribute this back into C# for VS Code if you're interested. In the meantime, I'll add some text to point folks to your extension.
@BryanHitchcock It's been a while since I looked into this, but I'm still open to the idea of doing this (and am happy to put in the effort if it's what users want and the OmniSharp team think it makes sense to do so 😄). I suspect this is mostly a deployment issue, rather than one of functionality (although I could be wrong) so it might be enough to ensure that MSBuild Project Tools gets installed when you install the C# extension? We previously discussed creating an extension pack but I don't think anyone's had a proper think about what that would look like so far.
Reacted by Bryan Hitchcock, Pau, Ben Holland and Immanuel Becker
Activity
DustinCampbell commentedon Jan 30, 2017
This will likely happen at some point, but not for awhile (unless somebody wants to contribute! 😄)
cmurczek-it commentedon Feb 6, 2017
Hi,
I'd be willing to give this a shot. I think this was/is a killer feature and I'm already starting to miss it! ;)
Are you planning on merging PR #224? In that case I should make the implementation for csproj somehow fit into what was there for project.json. Otherwise I'd use the project.json implementation as a template for csproj wherever it makes sense.
I'd start by raising the PR asap so you can easily follow up on progress. Since you tagged this issue as Backlog, should I target
masterorfuturewith my PR?Let me know your plans regarding #224 so I can compile the task list for my PR.
Cheers,
Christoph
DustinCampbell commentedon Feb 6, 2017
You're welcome to take a stab at it! It'll be quite some time before I'm able to get to this.
strake7 commentedon Mar 8, 2017
Indeed editing without the intellisense is a bit of a pain so I've been using the dotnet cli to manipulate nuget packages. Though I would use this should it be completed. Good luck!
tintoy commentedon Mar 8, 2017
BTW, there's a new extension for Visual Studio 2017 that provides
PackageReferenceintellisense:https://github.com/dotnet/ProjFileTools
Might help if anybody is curious about the mechanics of how to accomplish this.
DustinCampbell commentedon Mar 8, 2017
@mlorbetske and I were talking about how we might pull this into OmniSharp and C# for VS Code just yesterday.
stuartleeks commentedon Mar 14, 2017
Go go @mlorbetske :-)
[-]csproj intellisense plans?[/-][+]Implement completion for package references in csproj files[/+]DustinCampbell commentedon May 25, 2017
Unfortunately, this is going to have to move to 1.11. I've started looking at it, but other responsibilities got in the way this month.
11 remaining items
tintoy commentedon Aug 14, 2017
Hi.
It's not part of OmniSharp, but I finally bit the bullet and wrote an extension to provide basic completion for
PackageReferenceelements (package Ids and versions). I'm planning to eventually build out a full MSBuild language service behind it but it's probably good enough now for the most common use-case (packages from nuget.org - custom package sources fromNuGet.configwill be added in a later release). The NuGet v3 API is a little slow (but not infuriatingly so). Hopefully they'll improve it over time.BTW, I'm happy to contribute this functionality back to OmniSharp if it makes sense to do so.
ebekker commentedon Oct 6, 2017
The current changelog for C# extension reads "Known Issues in 1.12.0...There currently is no completion support for package references in csproj files. (#1156)"
Might be a good idea to add a link to @tintoy 's extension to tide people over in the interim. Or just simply adopt that extension wholesale as the official support.
DustinCampbell commentedon Oct 6, 2017
That's a very good idea (and thanks for bumping this issue to the top of my stack 😄).
@tintoy: I'd definitely work with you to contribute this back into C# for VS Code if you're interested. In the meantime, I'll add some text to point folks to your extension.
tintoy commentedon Oct 6, 2017
@DustinCampbell sure, I'm keen :)
ebekker commentedon Oct 8, 2017
Bonus -- @tintoy just added ability to toggle filtering of pre-release versions!
bryanhitc commentedon Jun 19, 2018
@DustinCampbell @tintoy Any update on this? It would be great to have this functionality integrated into C# for VS Code.
tintoy commentedon Jun 19, 2018
@BryanHitchcock It's been a while since I looked into this, but I'm still open to the idea of doing this (and am happy to put in the effort if it's what users want and the OmniSharp team think it makes sense to do so 😄). I suspect this is mostly a deployment issue, rather than one of functionality (although I could be wrong) so it might be enough to ensure that MSBuild Project Tools gets installed when you install the C# extension? We previously discussed creating an extension pack but I don't think anyone's had a proper think about what that would look like so far.
makakaorg commentedon Feb 22, 2020
Hi, do you have any progress? Fixing Date?
tilkinsc commentedon Dec 23, 2023
Whats the current state of things? There seems to be no alternatives.