Repository navigation
Need tooling to enforce style guide #4708
Description
Everyone agrees that from a style perspective, the intent is to have consistency in the code to make it more readable and maintainable. Update https://github.com/PowerShell/PowerShell/blob/master/docs/dev-process/coding-guidelines.md as needed, but should be enforced by tooling and not by PR comments.
- enforcement on the CI side
- enforcement on the developer side (part of Start-PSPester?)
Activity
iSazonov commentedon Aug 31, 2017
We already have PR #3504 for CI side and request from Jason Shirk (@lzybkr) for developer side (git commit hooks) in the PR.
[-]Need published style guide and tooling to enforce[/-][+]Need tooling to enforce style guide[/+]SteveL-MSFT commentedon Aug 31, 2017
Ilya (@iSazonov) you can close this once that PR is merged. Thanks!
iSazonov commentedon Aug 31, 2017
The PR s problematic - we can't merge it until we fix all files in the repo.
Also I believe we should address git commit hooks in another PR - I never write such hooks.
/cc Jason Shirk (@lzybkr)
daxian-dbw commentedon Sep 1, 2017
Travis Plunk (@TravisEz13) Could you please comment? I think you have more experience on this and have some ideas about how we can gradually roll out the files that are covered by the formatting checks.
iSazonov commentedon May 9, 2018
I see GitHub introduce
Checks. Can we use this?TravisEz13 commentedon May 9, 2018
I've seen other teams using https://www.codefactor.io/
iSazonov commentedon May 10, 2018
Screenshots look ver interesting. Can we try this in the repo?
TravisEz13 commentedon May 10, 2018
Steve Lee (@SteveL-MSFT) Dongbo Wang (@daxian-dbw) Aditya Patwardhan (@adityapatwardhan) What do you think? Can we try codefactor.io?
SteveL-MSFT commentedon May 10, 2018
Travis Plunk (@TravisEz13) I'm open to trying it out. I'll set it up.
adityapatwardhan commentedon May 10, 2018
I am open to trying it as long as it does not block PRs from being merged, at least to begin with.
SteveL-MSFT commentedon May 10, 2018
https://www.codefactor.io/repository/github/powershell/powershell/overview/master
21 remaining items
Add .editorconfig (#7357)
joeyaiello commentedon May 30, 2019
Steve Lee (@SteveL-MSFT) is this okay to close now?
vexx32 commentedon May 30, 2019
Do we have an omnisharp.json in the repo with the mentioned style rules set for VS Code users? Might be a good idea to do so if we haven't.
Also, I opened another issue already, but codefactor should definitely come back for those edge cases and misc recommendations.
SteveL-MSFT commentedon Jun 6, 2019
Joey Aiello (@joeyaiello) no, we need to integrate with CI
iSazonov commentedon Jun 6, 2019
Rain Sallow (/u/ta11ow) (@vexx32) We have .editorconfig as unified config for all editors.
microsoft-github-policy-service commentedon Nov 16, 2023
This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.
microsoft-github-policy-service commentedon Nov 16, 2023
This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.
microsoft-github-policy-service commentedon Nov 16, 2023
This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.
microsoft-github-policy-service commentedon Nov 23, 2023
This issue has been marked as "No Activity" as there has been no activity for 6 months. It has been closed for housekeeping purposes.
Format Utility `csproj` with updated `codeformatter` (PowerShell#7263)
Add .editorconfig (PowerShell#7357)