Skip to content

Clean up test code to use -Parameter syntax for Pester tests #6245

Description

Pester documentation for 4.x recommends using Should -Be instead of Should Be syntax. We should update all our tests and documentation to adhere to this setting a good example for the community.

Activity

  1. added this to the milestone on Feb 26, 2018
  2. iSazonov commented on Feb 26, 2018

    @iSazonov
    Collaborator

    Maybe Meta-Issue? I'd rather break the work apart otherwise we'll get a huge size PR which is hard to review.

    I guess Mark Kraus (@markekraus) grabs web cmdlet tests. I could grab something else, rest utility cmdlet tests.

  3. markekraus commented on Feb 26, 2018

    @markekraus
    Contributor

    hehe I planned to do this with the web cmdlet tests, yes.

  4. SteveL-MSFT commented on Feb 26, 2018

    @SteveL-MSFT
    MemberAuthor

    Ilya (@iSazonov) breaking it up makes sense!

  5. bergmeister commented on Feb 26, 2018

    @bergmeister
    Contributor

    I haven't tried it yet but here is a helper script to help with with upgrading to the new syntax. I have seen it being used by the xDFS repo already.

  6. added 4 commits that reference this issue on Mar 24, 2018
  7. KevinMarquette commented on Mar 24, 2018

    @KevinMarquette
    Contributor

    I have a PR out for these items on the list:
    PowerShellGet, PackageManagement, PSReadLine #6488
    SDK and Provider tests #6490

  8. KevinMarquette commented on Mar 26, 2018

    @KevinMarquette
    Contributor

    I have a PR out for the LocalAccounts module #6499

  9. xtqqczze commented on Jan 10, 2020

    @xtqqczze
    Contributor

    #6499 was not merged

  10. xtqqczze commented on Jan 10, 2020

    @xtqqczze
    Contributor

    Ilya (@iSazonov) Can you reopen?

  11. iSazonov commented on Jan 10, 2020

    @iSazonov
    Collaborator

    xtqqczze The Microsoft.PowerShell.LocalAccounts module was removed from PowerShell Core.

  12. xtqqczze commented on Jan 10, 2020

    @xtqqczze
    Contributor

    Ilya (@iSazonov) There is an issue to remplement (#4305) so we should still update pester syntax.

  13. iSazonov commented on Jan 10, 2020

    @iSazonov
    Collaborator

    xtqqczze It is impossible to get Microsoft.PowerShell.LocalAccounts module based on other API. We have to implement new module and new tests. (See my WIP PR for AccountManagement module)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalityIssue-Metaan issue used to track multiple issuesResolution-FixedThe issue is fixed.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions