Skip to content

Move to .Net Core 2.1 RC1-Final #6632

Closed

Description

@iSazonov

.Net Core 2.1 Preview2 is released.

We should move to the new version.

  1. Roll-forward in RTM and Self-contained Application Servicing
    This can affect the creation of security patches.
  2. Elimination of platform dependencies on libcurl
    We have some workarounds for libcurl. We should review this. "On Linux, you need to deploy libcurl yourself if you want to use the old HttpClient implementation."

Activity

  1. markekraus commented on Apr 12, 2018

    @markekraus
    Contributor

    hmm.. Should we really use a preview release? It's one thing to test it in a branch or something, prep for changes, and test for regressions, but we shouldn't commit a Preview release of .NET Core into PowerShell's Master, IMO.

  2. iSazonov commented on Apr 12, 2018

    @iSazonov
    CollaboratorAuthor

    Mark Kraus (@markekraus) Plan is to move .Net Core 2.1 Preview2 before PowerShell Core 6.1 Preview2.

    .Net Core 2.1 policy is "no breaking changes in APIs".
    My main concerns about the new HttpClient client but .Net Core allow use old implementation based on libcurl.

  3. SteveL-MSFT commented on Apr 12, 2018

    @SteveL-MSFT
    Member

    The PSCore6.1 release is essentially tied to the .Net Core 2.1 release because of some dependencies on 2.1. For the 6.1 Previews, I think it's fine to move to a dotnetcore Preview so we can find issues in dotnetcore and get those fixed before they move out of Preview.

  4. markekraus commented on Apr 12, 2018

    @markekraus
    Contributor

    Steve Lee (@SteveL-MSFT) Ok, do we have a contract that states that we will not ship 6.1 until 2.1 is GA? What if 2.1 is delayed several months beyond the planned 6.1 GA? Will we revert and ship or will we delay release until 2.1 is final?

    Ilya (@iSazonov) Right, no one is looking forward to getting rid of that libcurl dependency as much as I am. That doesn't mean we should merge a preview framework into master.

  5. iSazonov commented on Apr 12, 2018

    @iSazonov
    CollaboratorAuthor

    Mark Kraus (@markekraus) I had the same fears when we moved from 1.0 to 2.0 but Dongbo Wang (@daxian-dbw) did this job perfectly!
    It should be a lot easier now - it is 2.0 -> 2.1 not 2.0 -> 3.0. Initially it will be a PR that you can check locally before merging. We should do this as quickly as possible to identify all possible problems before GA.

  6. SteveL-MSFT commented on Apr 12, 2018

    @SteveL-MSFT
    Member

    Mark Kraus (@markekraus) We plan to have a new minor GA approx every 6 months, but we're not bound to that timeline. So if 2.1 slips, 6.1 will slip with it. Note that PSCore6 will not always have a hard dependency on latest dotnetcore.

  7. jherby2k commented on Apr 12, 2018

    @jherby2k

    Oh please oh please do it. Right now my binary module doesn't work under PSCore because it uses some of the Span APIs in System.Memory, which seem to conflict with the library in the 2.0 SDK.

  8. iSazonov commented on Apr 12, 2018

    @iSazonov
    CollaboratorAuthor

    Steve Lee (@SteveL-MSFT)

    Note that PSCore6 will not always have a hard dependency on latest dotnetcore.

    From https://blogs.msdn.microsoft.com/dotnet/2018/04/11/announcing-net-core-2-1-preview-2/ :

    dotnet publish now publishes self-contained applications with a serviced runtime version. When you publish a self-contained application with the new SDK, your application will include the latest serviced runtime version known by that SDK. When you upgrade to the latest SDK, you’ll publish with the latest .NET Core runtime version. This applies for .NET Core 1.0 runtimes and later.

  9. SteveL-MSFT commented on Apr 12, 2018

    @SteveL-MSFT
    Member

    Ilya (@iSazonov) I believe what that means is that when we publish with 2.1, we would automatically get a 2.1.1 servicing release if available, not that it would automatically move to 2.2-preview1 (for example) which is what I meant by "latest dotnetcore". Perhaps I should have said "latest dotnetcore preview".

  10. iSazonov commented on Apr 12, 2018

    @iSazonov
    CollaboratorAuthor

    Preview and RTM has different policy.
    Previews "do not roll forward from one preview to another or from preview to RTM."
    For RTM - "When you upgrade to the latest SDK, you’ll publish with the latest .NET Core runtime version. "

  11. SteveL-MSFT commented on Apr 12, 2018

    @SteveL-MSFT
    Member

    Correct, that means we need to explicitly move to latest Preview

  12. markekraus commented on Apr 18, 2018

    @markekraus
    Contributor

    Has anyone successfully made this work? I tried updating all of the references and installing the latest SDK but TypeGen ends up doing nothing and then the build dies with a sea of red.

  13. 14 remaining items

  14. markekraus commented on May 7, 2018

    @markekraus
    Contributor

    So now that the official 2.1 RC1 is out, do we need to make updates? https://blogs.msdn.microsoft.com/dotnet/2018/05/07/announcing-net-core-2-1-rc-1/

  15. SteveL-MSFT commented on May 7, 2018

    @SteveL-MSFT
    Member

    We should move to RC1-Final before Preview.3 ships. Should just involve updating global.json as we've made changes in tests/product necessary to move to 2.1

  16. changed the title [-]Move to .Net Core 2.1 Preview2 [/-] [+]Move to .Net Core 2.1 RC1-Final[/+] on May 7, 2018
  17. daxian-dbw commented on May 7, 2018

    @daxian-dbw
    Member

    Mark Kraus (@markekraus) Steve Lee (@SteveL-MSFT)
    The 2.1-rc1 SDK downloaded from the link given in the blog shows version 2.1.300-rc1-008673 with 2.1.0-rc1 Host and 2.1.0-rc1-final .NET Core rutnimes (see below). However, running Install-Dotnet -Channel release -Version 2.1.300-rc1-008673 with the same verison installs the same version of SDK but different Host/rutnimes versions.

    I'm not sure what went wrong, but it seems to me on the dotnet core side ...

    dotnet SDK download form the blog

    C:\>C:\Users\dongbow\Downloads\dotnet\dotnet.exe --info
    .NET Core SDK (reflecting any global.json):
     Version:   2.1.300-rc1-008673
     Commit:    f5e3ddbe73
    
    Runtime Environment:
     OS Name:     Windows
     OS Version:  10.0.16299
     OS Platform: Windows
     RID:         win10-x64
     Base Path:   C:\Users\dongbow\Downloads\dotnet\sdk\2.1.300-rc1-008673\
    
    Host (useful for support):
      Version: 2.1.0-rc1
      Commit:  eb9bc92051
    
    .NET Core SDKs installed:
      2.1.104 [C:\Program Files\dotnet\sdk]
      2.1.300-rc1-008673 [C:\Users\dongbow\Downloads\dotnet\sdk]
    
    .NET Core runtimes installed:
      Microsoft.AspNetCore.All 2.1.0-rc1-final [C:\Users\dongbow\Downloads\dotnet\shared\Microsoft.AspNetCore.All]
      Microsoft.AspNetCore.App 2.1.0-rc1-final [C:\Users\dongbow\Downloads\dotnet\shared\Microsoft.AspNetCore.App]
      Microsoft.NETCore.App 2.0.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
      Microsoft.NETCore.App 2.1.0-rc1 [C:\Users\dongbow\Downloads\dotnet\shared\Microsoft.NETCore.App]
    
    To install additional .NET Core runtimes or SDKs:
      https://aka.ms/dotnet-download
    

    dotnet SDK downloaded with Install-Dotnet -Channel release -Version 2.1.300-rc1-008673

    PS:8> C:\Users\dongbow\AppData\Local\Microsoft\dotnet\dotnet.exe --info
    .NET Core SDK (reflecting any global.json):
     Version:   2.1.300-rc1-008673
     Commit:    f5e3ddbe73
    
    Runtime Environment:
     OS Name:     Windows
     OS Version:  10.0.16299
     OS Platform: Windows
     RID:         win10-x64
     Base Path:   C:\Users\dongbow\AppData\Local\Microsoft\dotnet\sdk\2.1.300-rc1-008673\
    
    Host (useful for support):
      Version: 2.1.0-rc1-26428-03
      Commit:  2c36b039fd
    
    .NET Core SDKs installed:
      2.1.104 [C:\Program Files\dotnet\sdk]
      2.1.300-rc1-008673 [C:\Users\dongbow\AppData\Local\Microsoft\dotnet\sdk]
    
    .NET Core runtimes installed:
      Microsoft.AspNetCore.All 2.1.0-rc1-30682 [C:\Users\dongbow\AppData\Local\Microsoft\dotnet\shared\Microsoft.AspNetCore.All]
      Microsoft.AspNetCore.App 2.1.0-rc1-30682 [C:\Users\dongbow\AppData\Local\Microsoft\dotnet\shared\Microsoft.AspNetCore.App]
      Microsoft.NETCore.App 2.0.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
      Microsoft.NETCore.App 2.1.0-rc1-26428-03 [C:\Users\dongbow\AppData\Local\Microsoft\dotnet\shared\Microsoft.NETCore.App]
    
    To install additional .NET Core runtimes or SDKs:
      https://aka.ms/dotnet-download
    
  18. markekraus commented on May 7, 2018

    @markekraus
    Contributor

    Dongbo Wang (@daxian-dbw) weird. I get the 2.1.0-rc1 [sic] host when I do Install-Dotnet -Channel release -Version 2.1.300-rc1-008673

  19. SteveL-MSFT commented on May 8, 2018

    @SteveL-MSFT
    Member

    I see the same as Dongbo Wang (@daxian-dbw) on macOS. I'll reach out to the dotnet team on this.

  20. iSazonov commented on May 10, 2018

    @iSazonov
    CollaboratorAuthor
  21. SteveL-MSFT commented on May 10, 2018

    @SteveL-MSFT
    Member

    Dotnet team must be busy with Build as they aren't responding. Perhaps for now we should just wait for RTM if they are starting producing those builds.

  22. iSazonov commented on May 10, 2018

    @iSazonov
    CollaboratorAuthor

    While we could release 6.0.3 with latest .Net Core security updates. :-)

  23. markekraus commented on May 10, 2018

    @markekraus
    Contributor

    what ever happened to the 6.0.0 branch? I don't see it anymore. was it made private or moved somewhere?

  24. SteveL-MSFT commented on May 10, 2018

    @SteveL-MSFT
    Member

    Mark Kraus (@markekraus) 6.0.x servicing updates are done on a private branch since they contain security updates and we don't want to disclose the changes prematurely before the bits being publicly available

  25. SteveL-MSFT commented on May 15, 2018

    @SteveL-MSFT
    Member

    Got a response now that Build is over. They had an issue with CDN not having correct version, but that has since been fixed. If you still see wrong info with dotnet --info, try cleaning out ~/.dotnet folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions