Repository navigation
Update to dotnetcore2.1-rc1 - #6873
Conversation
Ilya (iSazonov)
left a comment
Ilya (iSazonov)
left a comment
There was a problem hiding this comment.
Leave a comment
Ilya (iSazonov)
left a comment
Ilya (iSazonov)
left a comment
There was a problem hiding this comment.
Files.wxs need fix.
| env: | ||
| global: | ||
| - CACHE_VERSION=netcoreapp.2.1-sdk.2.1.300-rc1-008662 | ||
| - CACHE_VERSION=netcoreapp.2.1-sdk.2.1.300-rc1 |
There was a problem hiding this comment.
Should this be rc1-008673 like in global.json or -final as in Weblistner.csproj?
There was a problem hiding this comment.
Travis Plunk (@TravisEz13) I see you added CACHE_VERSION to this yml. Searching travis-ci docs I don't see any mention of this var. I assumed this was just an opaque string since travis-ci wouldn't know anything specific about our version of dotnet, so the build number shouldn't be necessary
There was a problem hiding this comment.
Travis CI invalidate the cache when this env variable value changes, so it doesn't need to reflect the exact build number.
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.0-rc1-30676" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.0-rc1-final" /> |
There was a problem hiding this comment.
Is test/tools/WebListener/NuGet.config still necessary? Per our discussion at https://github.com/PowerShell/PowerShell/pull/6718/files#r185298874, it would not be needed when the packages are available on nuget.org.
There was a problem hiding this comment.
You're right, no longer needed. Will remove.
4 participants
PR Summary
2.1.300-rc1-008673 is the final build of RC1, may need to clean out ~/.dotnet folder if
dotnet --infoshows incorrect information.Update weblistener to aspnetcore 2.1.0-rc1-final
Fix #6632
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests