Skip to content

Fix type catalog #720

Closed
Closed

Description

Introduced in #719 at 78defa7, since the value for key System.Console is now mscorlib instead of System.Console in CorePsTypeCatalog.cs, tab completion of the assembly's types is broken.

$ [System.Console]::<tab>

Expect: TreatControlCAsInput etc.
Actual: just WriteLine

What's more, the types became inaccessible.

Expected:

$ [System.Console]::TreatControlCAsInput
False

Actual: nothing, nada, blank.

The CorePsTypeCatalog.cs relevant diff:

-            typeCatalog["System.Console"] = "System.Console, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a";
+            typeCatalog["System.Console"] = "mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e";

/cc Dongbo Wang (@daxian-dbw) Francisco Gamino (@Francisco-Gamino) Mike Richmond (@mirichmo)

Activity

  1. added
    Issue-BugIssue has been identified as a bug in the product
    Usability(LEGACY) Helps filter issues that might be higher priority because they directly affect usability
    on Mar 21, 2016
  2. andyleejordan commented on Mar 21, 2016

    @andyleejordan
    MemberAuthor

    I think this may stem from the fact that I feed it the runtime assemblies, instead of the reference assemblies, as I can't get a straight folder of the runtime assemblies.

    That in mind, I think I know the fix. I'll have to write some code to parse the project.lock.json and get the paths to all the reference assemblies, and feeds those the generator. That should fix it!

  3. Francisco-Gamino commented on Mar 22, 2016

    @Francisco-Gamino
    Contributor

    That sounds reasonable. Give it a try!

    On Mon, Mar 21, 2016 at 4:03 PM, Andy Schwartzmeyer <
    [email protected]> wrote:

    I think this may stem from the fact that I feed it the runtime assemblies,
    instead of the reference assemblies, as I can't get a straight folder of
    the runtime assemblies.

    That in mind, I think I know the fix. I'll have to write some code to
    parse the project.lock.json and get the paths to all the reference
    assemblies, and feeds those the generator. That should fix it!

    —
    You are receiving this because you were mentioned.
    Reply to this email directly or view it on GitHub
    #720 (comment)

  4. added a commit that references this issue on Mar 23, 2016
    d78852d
  5. added a commit that references this issue on Aug 6, 2026
    5ef1ad6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-BugIssue has been identified as a bug in the productUsability(LEGACY) Helps filter issues that might be higher priority because they directly affect usability

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions