Skip to content

Bring .cs code for CimCmdlets, WSMan.Management and WSMan.Runtime dlls - #1367

Merged
sergei (vors) merged 9 commits into
masterfrom
vors/3-dlls
Jul 14, 2016
Merged

Bring .cs code for CimCmdlets, WSMan.Management and WSMan.Runtime dlls#1367
sergei (vors) merged 9 commits into
masterfrom
vors/3-dlls

Conversation

@vors

@vors sergei (vors) commented Jul 14, 2016

Copy link
Copy Markdown
Collaborator

@vors

sergei (vors) commented Jul 14, 2016

Copy link
Copy Markdown
Collaborator Author

Dongbo Wang (@daxian-dbw) can you take a look, please?

@vors

sergei (vors) commented Jul 14, 2016

Copy link
Copy Markdown
Collaborator Author

cc Dan Travison (@dantraMSFT)

@vors

sergei (vors) commented Jul 14, 2016

Copy link
Copy Markdown
Collaborator Author

Note from Dan Travison (@dantraMSFT):

double check assemblyinfo.cs fir internalsvisibleto entries

daxian-dbw
daxian-dbw reviewed Jul 14, 2016
View reviewed changes
Comment thread src/Microsoft.Management.Infrastructure.CimCmdlets/project.json Outdated

@daxian-dbw Dongbo Wang (daxian-dbw) Jul 14, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it need to depend on "AssemblyLoadContext" and "Eventing"?

@vors sergei (vors) Jul 14, 2016

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I think this is a left-over from my copy-paste

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Jul 14, 2016

Copy link
Copy Markdown
Member

I cannot find the 'AssemblyInfo.cs' for wsman.management and wsman.runtime. I think we need to add them.
For wsman.management, you can refer to: (AssemblyVersionAttribute and SupressMessageAttributes)
%object_root%\admin\wmi\wmx\cmdlets\management\latest\objchk\amd64\AssemblyInfo.cs
%object_root%\admin\wmi\wmx\cmdlets\management\latest\objchk\amd64\_generated.cs

For wsman.runtime, you can refer to: (at least the AssemblyVersionAttribute is needed)
%object_root%\admin\wmi\wmx\cmdlets\runtime\latest\objchk\amd64\_generated.cs

@vors

sergei (vors) commented Jul 14, 2016

Copy link
Copy Markdown
Collaborator Author
  • AssemblyVersionAttribute thru dotnet cli version field, no need in putting it in AssemlbyInfo.cs
  • SupressMessageAttributes not needed as far as we don't use FxCop and we don't at the moment.

Sergei Vorobev and others added 8 commits July 14, 2016 13:46
Sergei Vorobev
Add map.json files
5802a02 
- Microsoft.WSMan.Runtime
- Microsoft.WSMan.Management
- Microsoft.Management.Infrastructure.CimCmdlets
Sergei Vorobev
Add project.json files
132d98e 
- Microsoft.WSMan.Runtime
- Microsoft.WSMan.Management
- Microsoft.Management.Infrastructure.CimCmdlets
@PowerShellTeam Sergei Vorobev
Copy cs files from [SD:717473]
bc6990f 
commit 96877403a6a2eb9dcbee0f71bbc6dfb6e61dd9a3

- Microsoft.WSMan.Runtime
- Microsoft.WSMan.Management
- Microsoft.Management.Infrastructure.CimCmdlets
Sergei Vorobev
Update PowerShellGithubDev.Tests.ps1
6c08715
@PowerShellTeam Sergei Vorobev
Convert txt resources into resx for Microsoft.WSMan.Management
160ab84
Sergei Vorobev
Update documentation about resources
2afedf3
Sergei Vorobev
Fix ResourceManager instantiation in WsManHelper.cs
eb0d690
Sergei Vorobev
Downgrade Microsoft.WSMan.Management dependency so we can use the one…
58de891 
… from sources
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Jul 14, 2016

Copy link
Copy Markdown
Member

:shipit:

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Jul 14, 2016

Copy link
Copy Markdown
Member

sergei (@vors) I believe some sub-projects have AssemblyVersionAttribute defined in AssemblyInfo.cs. We need to clean them up then.

@Indhukrishna

Indhu Sivaramakrishnan (Indhukrishna) commented Jul 14, 2016 •
edited by hiteshraigandhi
Loading

Copy link
Copy Markdown
Contributor

We need AssemblyInfo.cs for Wsman.Management and WSMan.Runtime. Else, they default to 1.0.0.0. But on Windows PowerShell, they need to be 3.0.0.0

@vors

sergei (vors) commented Jul 14, 2016

Copy link
Copy Markdown
Collaborator Author

Indhu Sivaramakrishnan (@Indhukrishna) it's controlled by this line: https://github.com/PowerShell/PowerShell/blob/vors/3-dlls/src/Microsoft.WSMan.Management/project.json#L3

@vors

sergei (vors) commented Jul 14, 2016

Copy link
Copy Markdown
Collaborator Author

Nope, my mistake: it's actually controlled by the attribute only.
Thanks Dongbo Wang (@daxian-dbw) and Indhu Sivaramakrishnan (@Indhukrishna) !

Sergei Vorobev
Add AssemlbyInfo.cs files
a655c9a 
- Microsoft.WSMan.Runtime
- Microsoft.WSMan.Management
- Microsoft.Management.Infrastructure.CimCmdlets
@Indhukrishna

Indhu Sivaramakrishnan (Indhukrishna) commented Jul 14, 2016

Copy link
Copy Markdown
Contributor

LGTM.
Do we need an AssemblyInfo.cs file for Cimcmdlets.dll? Without that, we default to 1.0.0.0
We could make it consistent across all binaries - to always have a default AssemblyInfo.cs.

@vors

sergei (vors) commented Jul 14, 2016

Copy link
Copy Markdown
Collaborator Author

Indhu Sivaramakrishnan (@Indhukrishna) It has over info we need (internal visible to).

I think explicit is better then implicit in this case.
We will revisit all versions, when we will update version of our produced nupkgs.

@vors
sergei (vors) merged commit 3276846 into master Jul 14, 2016
@vors
sergei (vors) deleted the vors/3-dlls branch July 14, 2016 23:17
This was referenced Jul 14, 2016
Closed
Closed
@andyleejordan

Andy Jordan (andyleejordan) commented Jul 18, 2016

Copy link
Copy Markdown
Member

/cc John Kordich (@johnkord)

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@vors
Merge pull request PowerShell#1367 from PowerShell/vors/3-dlls
6d1f11a 
Bring .cs code for CimCmdlets, WSMan.Management and WSMan.Runtime dlls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vors @daxian-dbw @Indhukrishna @andyleejordan @PowerShellTeam