Repository navigation
Fix ConvertFrom-Json to handle mutlilines - #1519
Merged
Merged
Conversation
Collaborator
Author
|
Francisco Gamino (@Francisco-Gamino) can you take a look, please? |
Contributor
|
The code change looks good. Please just fix the indentation of the #endregion. |
Fix #956 Add Newtonsoft.Json.JsonSerializationException to catch block that determines which mode to use: single-string or multi-string
| @@ -0,0 +1,16 @@ | |||
| Describe 'ConvertFrom-Json' { | |||
There was a problem hiding this comment.
There should be an existing file for JSON tests. Just a second.
There was a problem hiding this comment.
Oh I guess not. They're explicitly testing Newtonsoft.JSON interop (SDK/Json.Tests.ps1).
Member
|
LGTM. |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
Fix ConvertFrom-Json to handle mutlilines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
master.Fix #956
Add Newtonsoft.Json.JsonSerializationException to catch block
that determines which mode to use: single-string or multi-string