Enable crossgen for PowerShell binaries on Windows and Linux by Francisco-Gamino · Pull Request #1571 · PowerShell/PowerShell

Francisco Gamino (Francisco-Gamino) · 2016-07-29T17:20:15Z

Resolves issue

Native Image Generation for PowerShell libraries #1211

To generate ngen binaries for PowerShell, do the following:
ipmo .\build.psm1 -Force
Start-PSBuild -Publish -RemoveILs -CrossGen

This outputs:
publish: Published to C:\Users\frangom\Documents\GitHub\PowerShell\src\powershell-win-core\bin\Debug\netcoreapp1.0\win10-x64\publish
Published 1/1 projects successfully
Generating assembly Microsoft.PowerShell.Commands.Utility.ni.dll ...
Generating assembly Microsoft.PowerShell.Commands.Management.ni.dll ...
Generating assembly Microsoft.PowerShell.Security.ni.dll ...
Generating assembly Microsoft.PowerShell.CoreCLR.AssemblyLoadContext.ni.dll ...
Generating assembly Microsoft.PowerShell.CoreCLR.Eventing.ni.dll ...
Generating assembly Microsoft.PowerShell.ConsoleHost.ni.dll ...
Generating assembly Microsoft.PowerShell.LocalAccounts.ni.dll ...
Generating assembly Microsoft.PowerShell.Commands.Diagnostics.ni.dll ...
Generating assembly Microsoft.Management.Infrastructure.CimCmdlets.ni.dll ...
Generating assembly System.Management.Automation.ni.dll ...
PowerShell.exe with ngen binaries is available at C:\Users\frangom\Documents\GitHub\PowerShell/src/powershell-win-core\bin\Debug\netcoreapp1.0\win10-x64\publish\powershell.exe

After this, start PowerShell.exe from the following location: C:\Users\frangom\Documents\GitHub\PowerShell/src/powershell-win-core\bin\Debug\netcoreapp1.0\win10-x64\publish\powershell.exe

Code is rebased on origin/master.
Yes
Add tests that fail without your changes.
No tests needed for this code change
Update all relevant documentation.

sergei (vors) · 2016-07-29T17:30:06Z

Please, use ParameterSetName=Publish. CrossGen is a feature of Publish mode, not vice-verce

Good point. Fixed.

sergei (vors) · 2016-07-29T17:37:45Z

Please, update appveyor.yml (and later .travis.yml) to call CrossGen.

sergei (vors) · 2016-07-29T17:43:29Z

🕐

sergei (vors) · 2016-07-30T02:26:34Z

Switch with Mandatory=$true rarelly makes sense.
Please remove Mandatory for both $CrossGen and $RemoveILs

sergei (vors) · 2016-08-02T18:15:47Z

I think this parameter should be mandatory

sergei (vors) · 2016-08-02T18:25:03Z

Update AppVeyor.yml and travis.sh to use this funcitonality
🕐

Andy Jordan (andyleejordan) · 2016-08-03T17:50:28Z

This seems to be reverting sergei (@vors) changes from #1605

Francisco Gamino (@Francisco-Gamino) please, rebase

Andy Jordan (andyleejordan) · 2016-08-03T19:49:35Z

Fixed for OS X.

sergei (vors) · 2016-08-03T20:28:37Z

Same comment about consistent bracket. I suggest to ever fix it everywhere in the file or don't do this entirely.

I did just fix it everywhere.

My bad, I misread the diff

Might have pushed it just as you commented.

sergei (vors) · 2016-08-03T20:31:45Z

LGTM

It's a dylib, not a so.

Andy Jordan (andyleejordan) · 2016-08-03T21:14:39Z

We are a go!

Francisco Gamino (Francisco-Gamino) · 2016-08-03T21:15:08Z

+    # Add Windows specific libraries
+    if ($IsWindows) {
+        $psCoreAssemblyList += @(
+            "Microsoft.WSMan.Management.dll",


We should probably add a TODO to enable this once they are available on Linux.

Nope, as sergei (@vors) commented previously, these libraries will not come to Linux. They are explicitly Windows specific.

Ok. Then, we should be good to go.

Enable crossgen for PowerShell binaries on Windows and Linux

PowerShellTeam added the need review label Jul 29, 2016

Francisco Gamino (Francisco-Gamino) assigned Dongbo Wang (daxian-dbw) and sergei (vors) Jul 29, 2016

vors reviewed Jul 29, 2016
View reviewed changes

Jason Shirk (lzybkr) added the WG-Maintainers-Build specific to affecting the build label Jul 29, 2016

vors reviewed Jul 30, 2016
View reviewed changes

sergei (vors) added Review - waiting on author and removed Review - needed labels Jul 30, 2016

Francisco Gamino (Francisco-Gamino) changed the title ~~Enable crossgen for PowerShell binaries on Windows~~ Enable crossgen for PowerShell binaries on Windows and Linux Aug 2, 2016

Francisco Gamino (Francisco-Gamino) force-pushed the frangom/crossgen branch from db3e608 to 9bfbec4 Compare August 2, 2016 17:43

vors reviewed Aug 2, 2016
View reviewed changes

andyleejordan reviewed Aug 3, 2016
View reviewed changes

Francisco Gamino (Francisco-Gamino) force-pushed the frangom/crossgen branch from 99fb9d1 to 68df09f Compare August 3, 2016 18:29

Andy Jordan (andyleejordan) force-pushed the frangom/crossgen branch from 68df09f to e6618ec Compare August 3, 2016 19:47

Andy Jordan (andyleejordan) force-pushed the frangom/crossgen branch from e6618ec to 2fe4801 Compare August 3, 2016 19:50

Francisco Gamino (Francisco-Gamino) and others added 5 commits August 3, 2016 13:12

Enable crossgen for PowerShell assemblies on Linux

733c9f0

Addressing code review comments

58e7f48

Update Commands.Utility.csproj for WebCmdlet files

65eef96

Enable crossgen on CI

c16209e

Fix crossgen search for Ubuntu/CentOS

9c205c6

Andy Jordan (andyleejordan) force-pushed the frangom/crossgen branch 2 times, most recently from 499fc05 to 08e8966 Compare August 3, 2016 20:16

vors reviewed Aug 3, 2016
View reviewed changes

Andy Jordan (andyleejordan) added 2 commits August 3, 2016 13:36

Fix libclrjit name for OS X

c35c9e5

It's a dylib, not a so.

Fix inconsistent braces and whitespace in build.psm1

f866f8b

Andy Jordan (andyleejordan) force-pushed the frangom/crossgen branch from c2e0709 to f866f8b Compare August 3, 2016 20:36

Francisco-Gamino reviewed Aug 3, 2016
View reviewed changes

sergei (vors) merged commit 13b2da5 into master Aug 3, 2016

sergei (vors) deleted the frangom/crossgen branch August 3, 2016 21:15

Andy Jordan (andyleejordan) mentioned this pull request Aug 3, 2016

Native Image Generation for PowerShell libraries #1211

Closed

Travis Plunk (TravisEz13) added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Waiting on Author labels May 27, 2020

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026

Merge pull request PowerShell#1571 from PowerShell/frangom/crossgen

590762c

Enable crossgen for PowerShell binaries on Windows and Linux

Conversation

Francisco Gamino (Francisco-Gamino) commented Jul 29, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergei (vors) commented Jul 29, 2016

Uh oh!

sergei (vors) commented Jul 29, 2016

Uh oh!

sergei (vors) Jul 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergei (vors) commented Aug 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Andy Jordan (andyleejordan) commented Aug 3, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergei (vors) commented Aug 3, 2016

Uh oh!

Andy Jordan (andyleejordan) commented Aug 3, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sergei (vors) Jul 30, 2016 •

edited

Loading

sergei (vors) commented Aug 2, 2016 •

edited

Loading