Skip to content

Temporary workaround to fix the PSVersion issue in beta.1 release - #3740

Merged
Dongbo Wang (daxian-dbw) merged 2 commits into
masterfrom
version
May 9, 2017
Merged

Dongbo Wang (daxian-dbw) merged 2 commits into
masterfrom
version

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented May 9, 2017 •

Copy link
Copy Markdown
Member

private static SemanticVersion s_psV6Version = new SemanticVersion(6, 0, 0, "alpha");

Background: PSVersion is hard-coded in PSVersionInfo.cs, and this wasn't aware of until we pushed the release tag and built packages. This PR is a temporary workaround to unblock the release.

It includes 2 changes:

  1. Change s_psV6Version to new SemanticVersion(6, 0, 0, "beta");
    This version shouldn't be hard-coded, PSVersion in $PSVersionTable is hard-coded in PSVersionInfo.cs #3739 shall be fixed.
  2. Change Start-PSBuild to always write "v6.0.0-beta.1" to powershell.version.
    This hack shall be reverted after the release. Tracking by Revert the changes to 'Start-PSBuild' made in #3740 and #3742 after the beta.1 release #3741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants