Repository navigation
added test coverage for -notcontains, -is, -isnot operators - #4179
Merged
Travis Plunk (TravisEz13) merged 2 commits intoJul 11, 2017
Merged
Conversation
Steve Lee (SteveL-MSFT)
requested review from
James Truher (JamesWTruher) and
Aditya Patwardhan (adityapatwardhan)
July 3, 2017 22:18
Aditya Patwardhan (adityapatwardhan)
requested changes
Jul 6, 2017
| $arr= 'Hello','world' | ||
| $arr -contains 'Hello' | Should Be $true | ||
| It "Should be <result> for 'Hello','world' <operator> <rhs>" -TestCases @( | ||
| @{result = $true; operator = "-contains"; rhs = "'Hello'"}, |
There was a problem hiding this comment.
Test for case sensitive variants? ccontains and cnotcontains? There are some tests below. Can we move them to this It and add it as part of -TestCases array.
Member
Author
There was a problem hiding this comment.
I'll do some general cleanup of the tests
Member
Author
|
Aditya Patwardhan (@adityapatwardhan) addressed |
Aditya Patwardhan (adityapatwardhan)
approved these changes
Jul 8, 2017
Aditya Patwardhan (adityapatwardhan)
left a comment
Aditya Patwardhan (adityapatwardhan)
left a comment
Member
There was a problem hiding this comment.
LGTM
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
…#4179) * added test coverage for -notcontains, -is, -isnot operators * cleaned up tests to use -TestCases, added missing -cnotcontains test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-like and -contains already has coverage
Fix #4162