Skip to content

VS 2017 sln - #4748

Merged
Dongbo Wang (daxian-dbw) merged 4 commits into
PowerShell:masterfrom
lzybkr:vs_solution
Sep 19, 2017
Merged

VS 2017 sln#4748
Dongbo Wang (daxian-dbw) merged 4 commits into
PowerShell:masterfrom
lzybkr:vs_solution

Conversation

@lzybkr

@lzybkr Jason Shirk (lzybkr) commented Sep 4, 2017

Copy link
Copy Markdown
Contributor

I created a VS2017 solution file for the powershell-win-core csproj and everything it references.

It "upgraded" each csproj - but I reverted all changes but the one to suppress future upgrades.

The solution doesn't build and I haven't investigated why, but it's useful for editing across the entire project.

@iSazonov

Ilya (iSazonov) commented Sep 4, 2017

Copy link
Copy Markdown
Collaborator

Maybe put the file in root folder with PowerShell.Common.props file? Currently I use Staffan Gustafsson (@powercode) sln file such way.

@lzybkr

Jason Shirk (lzybkr) commented Sep 4, 2017

Copy link
Copy Markdown
Contributor Author

I'll defer to Dongbo Wang (@daxian-dbw) on taking the sln from Staffan Gustafsson (@powercode) or this one. I can move it to the root if we decide to take this.

daxian-dbw
Dongbo Wang (daxian-dbw) requested changes Sep 6, 2017
View reviewed changes
Comment thread src/powershell-win-core/powershell-win-core.csproj Outdated

@daxian-dbw Dongbo Wang (daxian-dbw) Sep 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is <RootNamespace> necessary to be added?
If so, can you please move it to the PropertyGroup section at top of the file?

@lzybkr Jason Shirk (lzybkr) Sep 18, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It avoids a warning when opening the solution. I moved it to the top.

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 6, 2017

Copy link
Copy Markdown
Member

I will take this .sln file since we already have a PR.
Jason Shirk (@lzybkr) please move the .sln to the root and rename it to PowerShell-Win.sln. VS2017 for Mac is available, so maybe someone will create a PowerShell-Mac.sln for that.

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 18, 2017

Copy link
Copy Markdown
Member

Jason Shirk (@lzybkr) Could you please address the comments when you have time? Thanks!

@lzybkr

Jason Shirk (lzybkr) commented Sep 18, 2017

Copy link
Copy Markdown
Contributor Author

Comments addressed and I rebased on master to fix the conflict.

daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Sep 18, 2017
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit de70969 into PowerShell:master Sep 19, 2017
@lzybkr
Jason Shirk (lzybkr) deleted the vs_solution branch September 19, 2017 17:47
@iSazonov Ilya (iSazonov) mentioned this pull request Sep 22, 2017
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@lzybkr @daxian-dbw
Add VS 2017 solution file for powershell-win-core (PowerShell#4748)
c9c338c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lzybkr @iSazonov @daxian-dbw @msftclas