Repository navigation
added CDXML CIM datetime test - #4796
Merged
Dongbo Wang (daxian-dbw) merged 2 commits intoSep 19, 2017
Merged
Conversation
Steve Lee (SteveL-MSFT)
requested a review
from James Truher (JamesWTruher)
September 10, 2017 03:32
Member
|
James Truher (@JamesWTruher) Could you please review this PR when you have time? Thanks! |
James Truher (JamesWTruher)
approved these changes
Sep 18, 2017
James Truher (JamesWTruher)
left a comment
James Truher (JamesWTruher)
left a comment
Collaborator
There was a problem hiding this comment.
this looks great
| $result = MofComp.exe ${script:createMof} | ||
| $testMof = Get-Content -Path ${script:createmof} -Raw | ||
| $currentTimeZone = [System.TimeZoneInfo]::Local | ||
| $UTCOffset = ($currentTimeZone.GetUtcOffset([datetime]::new(2008, 01, 01, 0, 0, 0))).TotalMinutes.ToString() |
Collaborator
There was a problem hiding this comment.
I was wondering if the 1/1/2008 date was special (since I hadn't got to the MOF change). Perhaps a comment indicating that this date is reflected in the MOF file.
Member
Author
There was a problem hiding this comment.
I'll add a comment that this date is not special but matches what is in the mof
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4169
Adds coverage to https://codecov.io/gh/PowerShell/PowerShell/src/ee0bb15b71738eb4ab67cd81d3deca182417116c/src/System.Management.Automation/utils/ClrFacade.cs
To make sure the test runs successfully on any machine in any timezone, needed to create the test mof during runtime with current UTC offset