Repository navigation
build: unbundle pester - #5623
Merged
Aditya Patwardhan (adityapatwardhan) merged 9 commits intoDec 5, 2017
Merged
Aditya Patwardhan (adityapatwardhan) merged 9 commits into
Aditya Patwardhan (adityapatwardhan) merged 9 commits into
Conversation
Travis Plunk (TravisEz13)
requested review from
Aditya Patwardhan (adityapatwardhan) and
Dongbo Wang (daxian-dbw)
as code owners
December 4, 2017 22:18
Dongbo Wang (daxian-dbw)
approved these changes
Dec 4, 2017
Dongbo Wang (daxian-dbw)
left a comment
Dongbo Wang (daxian-dbw)
left a comment
Member
There was a problem hiding this comment.
LGTM. Left some comments
| # spellcheck | ||
| - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then | ||
| mdspell '**/*.md' '!powershell/**/*.md' --ignore-numbers --ignore-acronyms --report; | ||
| mdspell '**/*.md' '!powershell/**/*.md' '!**/publish/**/*.md' --ignore-numbers --ignore-acronyms --report; |
There was a problem hiding this comment.
Can '!powershell/**/*.md' maybe be removed?
Member
Author
There was a problem hiding this comment.
Not sure what it was for.
Member
Author
There was a problem hiding this comment.
I removed it and it appears to not be needed. I added a comment to why my exclusion is there.
| $null = Start-NativeExecution {git clone --quiet $uri $clonePath} | ||
| Push-location | ||
| try { | ||
| Set-Location $clonePath |
There was a problem hiding this comment.
Minor: maybe use push-location $clonePath to combine push-location and set-location $clonePath
| { | ||
| pop-location | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: fix the indentation
James Truher (JamesWTruher)
approved these changes
Dec 5, 2017
James Truher (JamesWTruher)
left a comment
James Truher (JamesWTruher)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Aditya Patwardhan (adityapatwardhan)
approved these changes
Dec 5, 2017
Collaborator
|
Should we change our contribution docs too? |
Member
Author
|
Please feel free to file an issue |
Travis Plunk (TravisEz13)
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 6, 2017
* remove pester module * restore Pester as a module only in CI build from the git repo * mark appveyor builds as CI builds * remove pester exclusions * mark travis builds as ci * exclude publish folder from spell check * do not run spell check on publish folder # Conflicts: # tools/appveyor.psm1 # tools/travis.ps1
Travis Plunk (TravisEz13)
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 6, 2017
# Conflicts: # tools/appveyor.psm1 # tools/travis.ps1
Travis Plunk (TravisEz13)
added a commit
that referenced
this pull request
Dec 7, 2017
# Conflicts: # tools/appveyor.psm1 # tools/travis.ps1
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
* remove pester module * restore Pester as a module only in CI build from the git repo * mark appveyor builds as CI builds * remove pester exclusions * mark travis builds as ci * exclude publish folder from spell check * do not run spell check on publish folder
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
# Conflicts: # tools/appveyor.psm1 # tools/travis.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5458
-CIswitch tostart-PSBuild-CIis specified and-PSModuleRestore