Make Travis CI use libcurl+openssl+gssapi for macOS by markekraus · Pull Request #5629 · PowerShell/PowerShell

Mark Kraus (markekraus) · 2017-12-05T10:31:17Z

Closes #5590

makes Travis CI use the brew installed libcurl that uses OpenSSL for the crypto provider and include the gssapi option. The native libcurl provides inconsistent feature support across OS versions.
re-enable tests marked pending in Make the '-SslProtocol' tests pending #5605
GSSAPI is required for PowerShellGet in order to support HttpClientHandler.UseDefaultCredentials which it sets as true (unless you supply credentials).

PR Checklist

Note: Please mark anything not applicable to this PR NA.

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Update the changelog
User facing Documentation needed
- Issue filed - Issue link: Document macOS Web Cmdlet Limitations for 6.0.0 MicrosoftDocs/PowerShell-Docs#1926
Change is not breaking
[NA] Make sure you've added a new test, if existing tests do not effectively test the code changed
- Add [feature] if the change is significant or affectes feature tests

PR Summary

Mark Kraus (markekraus) · 2017-12-05T14:41:28Z

yay.. all passed this time.

So.. the question is where do I document this at? in the web cmdlets documentations? somewhere in this repo (install documentation)? both?

Dongbo Wang (daxian-dbw) · 2017-12-05T16:42:47Z

We need to document it in the web cmdlets help content, and point out what parameters are affected by this. docs/FAQ.md might also be a good place to keep this information.

Travis Plunk (TravisEz13)

One comment about another issue this PR brings up, Please file an issue or submit a PR for this and link in this PR.

Travis Plunk (TravisEz13) · 2017-12-06T00:58:57Z


                # Install patched version of curl
-                Start-NativeExecution { brew install curl --with-openssl } -IgnoreExitcode
+                Start-NativeExecution { brew install curl --with-openssl --with-gssapi } -IgnoreExitcode


We should update the PowerShell brew recipe as well.
https://github.com/caskroom/homebrew-cask/blob/master/Casks/powershell.rb#L33

We need to figure out what to do with the powershell package about this limitation on macOS.
CoreCLR has explicitly moved away from OpenSSL on mac, see this PR: dotnet/corefx#17011.
Please open an issue to track the macOS packaging about this.

opened Homebrew/homebrew-cask#41673

Travis Plunk (TravisEz13) · 2017-12-06T00:59:42Z

 - Remove Pester as a module include with the PowerShell Packages.
  In the future, you should be able to add it by running `Install-Module Pester`. (#5623, #5631)
+- Make Travis CI use `libcurl+openssl` (#5629, @markekraus)
+- Make Travis CI use `libcurl+openssl+gssapi` (#5629, @markekraus)


should only have one line for a single PR

Dongbo Wang (daxian-dbw) · 2017-12-06T17:40:53Z

I didn't add the [feature] tag when resolving a conflict. Add the [feature] to trigger full test run.

Mark Kraus (markekraus) added the Documentation Needed in this repo Documentation is needed in this repo label Dec 5, 2017

Mark Kraus (markekraus) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners December 5, 2017 10:31

Mark Kraus (markekraus) changed the title ~~Make Travis CI use libcurl+openssl~~ Make Travis CI use libcurl+openssl+gssapi Dec 5, 2017

Mark Kraus (markekraus) force-pushed the macOsLibcurlFix branch from 65a4929 to a758be9 Compare December 5, 2017 12:27

Dongbo Wang (daxian-dbw) approved these changes Dec 5, 2017

View reviewed changes

Dongbo Wang (daxian-dbw) force-pushed the macOsLibcurlFix branch from e232177 to bbbf5f8 Compare December 6, 2017 00:51

Mark Kraus (markekraus) added 3 commits December 5, 2017 16:53

[feature] Make Travis CI use libcurl+openssl

a4e4e6a

[feature] Update changelog

c88192e

[feature] Add GSSAPI to libcurl

3c9e098

Dongbo Wang (daxian-dbw) force-pushed the macOsLibcurlFix branch from bbbf5f8 to 3c9e098 Compare December 6, 2017 00:53

Travis Plunk (TravisEz13) approved these changes Dec 6, 2017

View reviewed changes

Dongbo Wang (daxian-dbw) self-assigned this Dec 6, 2017

This was referenced Dec 6, 2017

Update powershell 6.0.0-rc Add GSSAPI support to caveat Homebrew/homebrew-cask#41673

Merged

macOS Packaging and libcurl+openssl+gssapi #5635

Closed

[feature] Remove duplicate entry in ChangeLog.md

5f96cc6

Dongbo Wang (daxian-dbw) force-pushed the macOsLibcurlFix branch from e6896f0 to 5f96cc6 Compare December 6, 2017 17:39

Dongbo Wang (daxian-dbw) merged commit ee7fbed into PowerShell:master Dec 6, 2017

Dongbo Wang (daxian-dbw) changed the title ~~Make Travis CI use libcurl+openssl+gssapi~~ Make Travis CI use libcurl+openssl+gssapi for macOS Dec 6, 2017

Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 7, 2017

Make Travis CI use libcurl+openssl+gssapi for macOS (PowerShell#5629)

171ee52

Travis Plunk (TravisEz13) mentioned this pull request Dec 7, 2017

Move 6.0.0 rc.2 changes #5646

Merged

Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Dec 7, 2017

Make Travis CI use libcurl+openssl+gssapi for macOS (#5629)

721d3e9

Travis Plunk (TravisEz13) added this to the 6.0.0-RC.2 milestone Dec 8, 2017

Mark Kraus (markekraus) deleted the macOsLibcurlFix branch January 19, 2018 19:00

Joey Aiello (joeyaiello) mentioned this pull request Oct 15, 2018

Docs needed for 'Make Travis CI use libcurl+openssl+gssapi for macOS' MicrosoftDocs/PowerShell-Docs#3059

Closed

Joey Aiello (joeyaiello) removed the Documentation Needed in this repo Documentation is needed in this repo label Oct 15, 2018

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026

Make Travis CI use libcurl+openssl+gssapi for macOS (PowerShell#5629)

2341f39

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026

Make Travis CI use libcurl+openssl+gssapi for macOS (PowerShell#5629)

cdb7a7d

Navigation Menu

Repository navigation

Make Travis CI use libcurl+openssl+gssapi for macOS - #5629

Make Travis CI use libcurl+openssl+gssapi for macOS#5629
Dongbo Wang (daxian-dbw) merged 4 commits into
PowerShell:masterfrom
markekraus:macOsLibcurlFix

Mark Kraus (markekraus) commented Dec 5, 2017 •

edited

Loading

Uh oh!

Mark Kraus (markekraus) commented Dec 5, 2017

Uh oh!

Dongbo Wang (daxian-dbw) commented Dec 5, 2017 •

edited

Loading

Uh oh!

Travis Plunk (TravisEz13) left a comment

Uh oh!

Travis Plunk (TravisEz13) Dec 6, 2017

Uh oh!

Dongbo Wang (daxian-dbw) Dec 6, 2017

Uh oh!

Mark Kraus (markekraus) Dec 6, 2017

Uh oh!

Mark Kraus (markekraus) Dec 6, 2017

Uh oh!

Travis Plunk (TravisEz13) Dec 6, 2017

Uh oh!

Dongbo Wang (daxian-dbw) commented Dec 6, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Mark Kraus (markekraus) commented Dec 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Summary

Uh oh!

Mark Kraus (markekraus) commented Dec 5, 2017

Uh oh!

Dongbo Wang (daxian-dbw) commented Dec 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Travis Plunk (TravisEz13) left a comment

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) Dec 6, 2017

Choose a reason for hiding this comment

Uh oh!

Dongbo Wang (daxian-dbw) Dec 6, 2017

Choose a reason for hiding this comment

Uh oh!

Mark Kraus (markekraus) Dec 6, 2017

Choose a reason for hiding this comment

Uh oh!

Mark Kraus (markekraus) Dec 6, 2017

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) Dec 6, 2017

Choose a reason for hiding this comment

Uh oh!

Dongbo Wang (daxian-dbw) commented Dec 6, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Mark Kraus (markekraus) commented Dec 5, 2017 •

edited

Loading

Dongbo Wang (daxian-dbw) commented Dec 5, 2017 •

edited

Loading