Skip to content

Fix New-TemporaryFile online help URI - #6608

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
adityapatwardhan:FixTempFileHelpLink
Jun 20, 2018
Merged

Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
adityapatwardhan:FixTempFileHelpLink

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Apr 9, 2018 •

Copy link
Copy Markdown
Member

Fixes #6186

PR Summary

Fix the link for online help content for New-TemporaryFile.

PR Checklist

/// The implementation of the "New-TemporaryFile" cmdlet
/// </summary>
[Cmdlet(VerbsCommon.New, "TemporaryFile", SupportsShouldProcess = true, HelpUri = "https://go.microsoft.com/fwlink/?LinkId=526726")]
[Cmdlet(VerbsCommon.New, "TemporaryFile", SupportsShouldProcess = true, HelpUri = "https://go.microsoft.com/fwlink/?LinkId=821836")]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For most of our cmdlets we default to 5.1. Joey Aiello (@joeyaiello) Are we going to change the default to 6?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the new fwlink points to 5.1, and IMO it should probably point to the version-agnostic link (for which we can change the default later). This way, when we update to 6, we can rev the default for all modules on docs.microsoft.com to 6.1, and then we don't have to change the fwlinks.

However, if we go that route, we need to make sure that 6 has distinct fwlinks from 5.1, and i'm not sure we've got that work fully understood or costed (that's a lot of fwlinks).

@stale

stale Bot commented May 11, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale Bot added the Stale label May 11, 2018
@adityapatwardhan

Copy link
Copy Markdown
Member Author

Dan Travison (@dantraMSFT) The link now forwards to v6. Can you have another look?

@stale stale Bot removed the Stale label May 11, 2018
@iSazonov

Copy link
Copy Markdown
Collaborator

Is the PR ready to merge?

@anmenaga

Copy link
Copy Markdown

Travis Plunk (@TravisEz13) Ready for Merge.

@adityapatwardhan

Copy link
Copy Markdown
Member Author

Travis Plunk (@TravisEz13) ok to merge?

@TravisEz13
Travis Plunk (TravisEz13) merged commit d76cdc3 into PowerShell:master Jun 20, 2018
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the FixTempFileHelpLink branch July 13, 2018 21:50
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cmdlet Help link broken for New-TemporaryFile

6 participants