Repository navigation
Use dotnet-resgen to compile resx files - #743
Merged
Merged
Conversation
Needs to be `processName`, not `program`. Go figure.
Specifically this enables us to leverage `dotnet-resgen` to auto-generate the `resx` files into `resources` files for the default culture, which are then compiled into the SMA assembly. This requires a change to the C# bindings. The Windows build system takes `file.resx` and compiles `file.resources`, but CLI prepends the assembly name, thus compiling `SMA.file.resources`. So the resource manager in the generated bindings must be adjusted to look for `SMA.file` instead of `file`. Note that C# bindings cannot yet be auto-generated. Given localized resources of the form `file.en-US.resx`, `dotnet-resgen` will create a satellite assembly and publish it to `en-US/SMA.resources.dll`, so #666 will not be a technical problem.
This is a runtime dependency that causes an internal exception to be thrown and caught when not available.
So that the resource manager doesn't try to load a non-existent satellite assembly (and thus throw). The culture `en-US` is the default `CurrentCulture` on all platforms I tested, specifically not `en`. Note that there is a problem with the FullCLR build where some other assembly is still attempting to reference `Logging.resources` instead of `System.Management.Automation.Logging.resources`.
Member
Author
|
sergei (@vors) I'm going to need some help making this work with the FullCLR build. There is a problem with the FullCLR build where some other assembly is still attempting to reference |
Collaborator
|
ok, lets take a look on Tuesday |
Member
Author
|
Here it is: This error would make sense if SMA's resource C# bindings had not been fixed. However, as evidenced from Core and Linux working, SMA indeed is fine. So what, outside of our code, would be using SMA's resource bindings directly? |
Member
Author
|
Found it. The This now requires PowerShell/psl-monad#42 too. |
This was referenced Mar 28, 2016
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
Use dotnet-resgen to compile resx files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement
Specifically this enables us to leverage
dotnet-resgento auto-generate theresxfiles intoresourcesfiles for the default culture, which are then compiled into the respective assemblies.sergei (@vors) Since
.resourcesno longer need to be compiled on Windows and added towindows-build, #732 should be updated to map the.resxfiles into the superproject as well.Requires PowerShell/psl-windows-build#10.
Caveat
This requires a change to the C# bindings. The Windows build system takes
file.resxand compilesfile.resources, but CLI prepends the assembly name, thus compilingSMA.file.resources. So the resource manager in the generated bindings must be adjusted to look forSMA.fileinstead offile.Note that C# bindings cannot yet be auto-generated; so if they need to be updated, the above must be changed again. This is still blocked on #395 / dotnet/cli#819. However, the C# bindings need to be updated only if strings are added/removed, not when their content changes.
Localization
sergei (@vors) I've discovered that given localized resources of the form
file.en-US.resx,dotnet-resgenwill create a satellite assembly and publish it toen-US/SMA.resources.dll, so #666 will not be a technical problem./cc Steve Lee (@SteveL-MSFT) Bruce Payette (@BrucePay) Dan Travison (@dantraMSFT)
This change is