Repository navigation
Remove clone args - #7910
Merged
Travis Plunk (TravisEz13) merged 3 commits intoOct 29, 2018
Merged
Remove clone args#7910
Conversation
Ilya (iSazonov)
added
the
Issue-Code Cleanup
Ilya (iSazonov)
requested review from
Paul Higinbotham (PaulHigin) and
Travis Plunk (TravisEz13)
October 1, 2018 13:24
Ilya (iSazonov)
requested review from
Andrew (anmenaga) and
Dongbo Wang (daxian-dbw)
as code owners
October 1, 2018 13:24
Member
|
Dongbo Wang (@daxian-dbw) Not sure why this was there in the first place. |
Andrew (anmenaga)
suggested changes
Oct 10, 2018
There was a problem hiding this comment.
It would be good to get a [feature] test pass on this. Thanks.
Also, Dongbo Wang (@daxian-dbw) any ideas regarding Travis's question? I wonder the same thing as well...
There was a problem hiding this comment.
We should probably leave the null check in the code.
Collaborator
Author
There was a problem hiding this comment.
Is c# convention that args is never null?
- args is never null - the code is not used
Ilya (iSazonov)
force-pushed
the
remove-clone-args
branch
from
October 12, 2018 03:58
61de45f to
d0d0300
Compare
Andrew (anmenaga)
approved these changes
Oct 25, 2018
Collaborator
Author
|
Dongbo Wang (@daxian-dbw) Can you confirm that we can merge? |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Close #7457.
The cleanup is needed after #7449 and #2538.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests