Skip to content

Replace StringComparision.CurrentCulture with StringComparision.Ordinal - #8068

Merged
Ilya (iSazonov) merged 25 commits into
PowerShell:masterfrom
iSazonov:cleanup-culture
Oct 21, 2018
Merged

Replace StringComparision.CurrentCulture with StringComparision.Ordinal#8068
Ilya (iSazonov) merged 25 commits into
PowerShell:masterfrom
iSazonov:cleanup-culture

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Oct 18, 2018 •
edited by TravisEz13
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Related #8064

Replace StringComparision.CurrentCulture with StringComparision.Ordinal.

Best Practices for Using Strings in .NET

Not all code base is fixed. There are not obvious cases.

PR Checklist

This change is Reviewable

@iSazonov Ilya (iSazonov) added the Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality label Oct 18, 2018
@iSazonov Ilya (iSazonov) self-assigned this Oct 18, 2018
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 18, 2018

Copy link
Copy Markdown
Member

src/Microsoft.WSMan.Management/WSManConnections.cs, line 143 at r1 (raw file):

            {
                computername = value;
                if ((string.IsNullOrEmpty(computername)) || (computername.Equals(".", StringComparison.OrdinalIgnoreCase)))

I've seen this in many places, perhaps we should have a central place for this code?

TravisEz13
Travis Plunk (TravisEz13) reviewed Oct 18, 2018
View reviewed changes

@TravisEz13 Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 24 of 24 files at r1.
Reviewable status: :shipit: complete! all files reviewed

@TravisEz13

Travis Plunk (TravisEz13) commented Oct 18, 2018

Copy link
Copy Markdown
Member

We probably should fix this one as well:

PowerShell/src/System.Management.Automation/engine/parser/SafeValues.cs

Line 641 in 2f1863a

Hashtable hashtable = new Hashtable(StringComparer.CurrentCultureIgnoreCase);

@TravisEz13

Travis Plunk (TravisEz13) commented Oct 18, 2018

Copy link
Copy Markdown
Member

Thinking about it further with James Truher (@JamesWTruher) , Hashtable could be culture sensitive in some cases. This should be a different PR and probably be behind an experimental flag.

@iSazonov

Ilya (iSazonov) commented Oct 19, 2018

Copy link
Copy Markdown
Collaborator Author

Hashtable could be culture sensitive in some cases.

Travis Plunk (@TravisEz13) In the PR I fixed only obvious cases. There are still about 30 unclear cases left. It would be great if MSFT team reviewed them.

I've seen this in many places, perhaps we should have a central place for this code?

If we should please open a tracking issue and I'll fix this later.

@iSazonov
Ilya (iSazonov) merged commit 0a4f33a into PowerShell:master Oct 21, 2018
@iSazonov
Ilya (iSazonov) deleted the cleanup-culture branch October 21, 2018 11:11
@iSazonov Ilya (iSazonov) mentioned this pull request Dec 31, 2018
Merged
8 of 11 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov
Replace StringComparision.CurrentCulture with StringComparision.Ordin…
5467f7b 
…al (PowerShell#8068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner
@powercode Staffan Gustafsson (powercode) Awaiting requested review from powercode
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
@Francisco-Gamino Francisco Gamino (Francisco-Gamino) Awaiting requested review from Francisco-Gamino
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher

Assignees

@iSazonov Ilya (iSazonov)

Labels

Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iSazonov @TravisEz13