Skip to content

Converge the console hosts - #939

Merged
Andy Jordan (andyleejordan) merged 56 commits into
masterfrom
andschwa/consolehost
May 17, 2016
Merged

Converge the console hosts#939
Andy Jordan (andyleejordan) merged 56 commits into
masterfrom
andschwa/consolehost

Conversation

@andyleejordan

@andyleejordan Andy Jordan (andyleejordan) commented May 3, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

This resolves #495 and #912. This is a work-in-progress, do not merge.

Next steps:

  • fully deprecate powershell-native custom host
  • ensure FullCLR build can still work
  • remove deprecated CoreConsoleHost project
  • deprecate or reimplement consoleHostFile feature
  • fix mark failing tests as pending
  • deploy modules in build script rather than as content use files like in libuv use shim project
  • merge our managed ReadLine backup use System.Console.ReadLine()
  • accept --flags
  • fix stdin/stdout/stderr stream writers
  • fix non-interactive use of BufferSize
  • fix Linux CI
  • fix OS X CI (~31 marked as pending until further notice)
  • fix Windows CI
  • fix output when there is no TTY (mostly)

How it was done:

The managed RawUserInterface from CoreConsoleHost was used to replace the Windows-centric ConsoleControl of the ConsoleHost. The work done to port PSReadLine to Linux enabled a much easier replacement of the ReadLine aspects of ConsoleHostUserInterface. While this deprecates our previous ReadLine implementation; it was required to push .NET Core to implement the APIs necessary to port PSReadLine. The managed entrance Start function is replaced with a Main function for the dotnet native host to build an app.

This change is Reviewable

@andyleejordan Andy Jordan (andyleejordan) mentioned this pull request May 4, 2016
Closed
1 of 4 tasks
@andyleejordan Andy Jordan (andyleejordan) added the Usability (LEGACY) Helps filter issues that might be higher priority because they directly affect usability label May 4, 2016
This was referenced May 4, 2016
Closed
Merged
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the andschwa/consolehost branch 2 times, most recently from 2f21682 to 8c960f3 Compare May 5, 2016 21:31
@andyleejordan Andy Jordan (andyleejordan) mentioned this pull request May 5, 2016
Closed
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the andschwa/consolehost branch 2 times, most recently from e4bfc7e to a8ae949 Compare May 6, 2016 21:46
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the andschwa/consolehost branch 8 times, most recently from b1f3477 to 203cb21 Compare May 11, 2016 21:23
@andyleejordan Andy Jordan (andyleejordan) added this to the v0.4.0 milestone May 11, 2016
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the andschwa/consolehost branch 4 times, most recently from 17650d9 to 6559c8d Compare May 11, 2016 22:59
@andyleejordan

Andy Jordan (andyleejordan) commented May 11, 2016

Copy link
Copy Markdown
Member Author

This is seriously annoying. These pass locally on both Windows and Linux... but I'm having problems getting them to run correctly in AppVeyor's environment where there are no Console handles.

@andyleejordan

Andy Jordan (andyleejordan) commented May 12, 2016

Copy link
Copy Markdown
Member Author

The non-pending Linux, OS X, and Windows tests all pass locally.

@andyleejordan

Andy Jordan (andyleejordan) commented May 13, 2016

Copy link
Copy Markdown
Member Author

I've narrowed down the OS X test failures to be caused by the lack of a TTY on the OS X test runner (which is strange, considering that the Linux runner has a TTY, and Travis already tracked and fixed a bug where OS X did not have a TTY allocated; thus I believe it to be a regression).

@andyleejordan

Andy Jordan (andyleejordan) commented May 13, 2016

Copy link
Copy Markdown
Member Author

For reference, previous Travis bug is travis-ci/travis-ci/issues/2872. Nonetheless, I think that ConsoleHost should work properly without a TTY.

Andy Jordan (andyleejordan) and others added 21 commits May 17, 2016 13:28
@andyleejordan
Mark as pending tests not working with ConsoleHost
c3eaf9a
@andyleejordan
Fix AppVeyor to use Get-PSOutput
7f491be 
Instead of hard-coded paths.
@andyleejordan
Add -noprofile to Start-PSPester
e387961
@andyleejordan
Use -noprofile on AppVeyor
aa8dc7c
@lzybkr @andyleejordan
Add ConsoleHost tests
8c97fd1
@andyleejordan
Skip complex prompting tests
6d7b6a1 
Not supported with non-PSReadLine Open PowerShell host.
@andyleejordan
Use -noninteractive on AppVeyor
0dc549e
@andyleejordan
Don't build more unused code
86e8673 
This code is all used for reading secure strings, which we don't yet
support.
@andyleejordan
Guard BufferSize for improper terminals
fbc794b
@andyleejordan
Mark redirected input test as pending on Windows
6cd7804 
While this passes on Linux, it does not pass on Windows, indicating a
platform-specific bug in .NET Core.
@andyleejordan
Clean up Set-PSDebug tests
2fdf481
@andyleejordan
Fix Import-Alias tests
fe53280
@andyleejordan
Use Pending for tests that shouldn't be Skipped
2712cea
@andyleejordan
Disable Set-PSDebug tests on AppVeyor
d1c2a2c 
These pass locally, just not with AppVeyor's host.
@andyleejordan
Remove env key from OS X build
800fa4c 
`Start-PSBootstrap` takes care of this.
@andyleejordan
Enable pre and post write in WriteToConsole
fa86c89
@andyleejordan
Fix formatting and output when stdout is redirected
44028f0
@andyleejordan
Mark as pending Travis CI OS X failing tests
7e65fa4 
These tests *do not* fail locally, nor on the Linux test runner. They do
not fail when accessing the OS X runner under debug mode. The *only*
cause is the lack of a TTY on the OS X runner, which is a Travis CI
regression. Moreover, the formatting tests do not fail when the TTY is
removed locally.

These absolutely should be fixed at some point, but it is not worth
spending any more time on it.
@andyleejordan
Rename OPEN flag to PORTABLE
772ecb8 
Makes more sense.
@andyleejordan
Say that the portable UI supports virtual terminal
7afe9aa 
Which is most likely true.
@andyleejordan
Use WrapSize for WindowSize when unavailable
b67d765
@andyleejordan
Andy Jordan (andyleejordan) force-pushed the andschwa/consolehost branch 2 times, most recently from bc8f6eb to 2df16d0 Compare May 17, 2016 20:35
@andyleejordan
Fix ReadLineWithTabCompletion port
64efb9d 
Revert change made within the function since the function itself is
compiled out for the portable version of PowerShell.
@lzybkr

Jason Shirk (lzybkr) commented May 17, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

LGTM

@andyleejordan
Andy Jordan (andyleejordan) deleted the andschwa/consolehost branch May 17, 2016 21:44
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@andyleejordan
Merge pull request PowerShell#939 from PowerShell/andschwa/consolehost
9b86e25 
Converge the console hosts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@andyleejordan Andy Jordan (andyleejordan)

Labels

Usability (LEGACY) Helps filter issues that might be higher priority because they directly affect usability

Projects

None yet

Milestone

v0.4.0

Development

Successfully merging this pull request may close these issues.

Port features from ConsoleHost to Cross-Platform Host

3 participants

@andyleejordan @vors @lzybkr