Skip to content

Change the publishId in VS Code marketplace #690

Description

@renkun-ken

Since the project has been transferred to REditorSupport as suggested in #98, we may better have a discussion on the issue of changing publishId in the VS Code marketplace here.

When the repo is transferred, the following are examples for both sides: changing or keeping the publishId.

Changed:
Unchanged: dbaeumer.vscode-eslint, esbenp.prettier-vscode

Some related issues:

Activity

  1. Ikuyadeu commented on Jul 1, 2021

    @Ikuyadeu
    Member

    When I discussed with them, I got the opinion to keep the current id for users' experience.
    But I'll ask again about differences with your examples.

  2. eitsupi commented on Jul 1, 2021

    @eitsupi
    Member

    Thank you all for your continued work.

    Looking at the Prettier extension, it seems that the ID of the extension remains the same even if the publisher is changed. If it is changed, will it affect the user?
    image

  3. renkun-ken commented on Jul 1, 2021

    @renkun-ken
    MemberAuthor

    @eitsupi Thanks for pointing out. Looks like the case of changed publishId is quite few?

  4. Ikuyadeu commented on Jul 1, 2021

    @Ikuyadeu
    Member

    publishid and author are different.
    Changing author, does not have any impact on the user.
    I think, Yuki Ueda to be REditor is enough.

    -  "author": "Yuki Ueda",
    +  "author": "REditor",
       "license": "SEE LICENSE IN LICENSE",
       "publisher": "Ikuyadeu",
  5. renkun-ken commented on Jul 1, 2021

    @renkun-ken
    MemberAuthor

    To be consistent with the organization name and vscode-r-lsp, the author should be "REditorSupport".

  6. eitsupi commented on Jul 1, 2021

    @eitsupi
    Member

    The Prettier extension seems to have changed publishers in March of this year when it was no longer in beta?
    prettier/prettier-vscode@78ae1a5

  7. eitsupi commented on Jul 1, 2021

    @eitsupi
    Member

    It seems that the Prettier extension has changed its publisher several times between esbenp and prettier in order to publish the development version as a separate ID, and the stable version has not changed from esbenp.
    https://marketplace.visualstudio.com/items?itemName=prettier.prettier-vscode
    https://marketplace.visualstudio.com/items?itemName=prettier.prettier-vscode-beta

  8. renkun-ken commented on Jul 2, 2021

    @renkun-ken
    MemberAuthor

    From the existing cases, it looks like we might better stick to the current publishId and only update the author.

  9. randy3k commented on Jul 2, 2021

    @randy3k
    Member

    Thanks for initiating the discussion. Looks like we could stick with the current publisher for now.

    We could consider it again in the future if there is a necessity (e.g. cannot publish releases). An alternative but less ideal solution is to publish a new extension under REditorSupport and deprecate this extension.

  10. randy3k commented on Oct 17, 2021

    @randy3k
    Member

    It seems changing the author of a package is not enough to change the display name on the extension page.

    For the case of https://marketplace.visualstudio.com/publishers/esbenp. The publisher id is esbenp and the display name is "Prettier".
    It is possible for @Ikuyadeu to change his display name to "REditorSupport" but I wonder if he wants to do it because it would apply to all his other extensions.

    @Ikuyadeu, do you mind transferring the extension to the publisher REditorSupport which you are already one of the owners alongside @renkun-ken and me.

  11. Ikuyadeu commented on Oct 18, 2021

    @Ikuyadeu
    Member

    It is possible for @Ikuyadeu to change his display name to "REditorSupport" but I wonder if he wants to do it because it would apply to all his other extensions.

    I can not change my display name, because I have other extensions that are crated with other teams.

    @Ikuyadeu, do you mind transferring the extension to the publisher REditorSupport which you are already one of the owners alongside @renkun-ken and me.

    I already send the request to the Microsoft microsoft/vsmarketplace#133 microsoft/vsmarketplace#142

  12. randy3k commented on Oct 18, 2021

    @randy3k
    Member

    I recall that we did the transfer of vscode-r-lsp via email. Perhaps you could send an email to [email protected] to initiate the transfer.

  13. isidorn commented on Mar 31, 2022

    @isidorn

    Hi VS Code PM here 👋

    I apologise that the Marketplace team did not respond to your request.
    Can the current extension author please email [email protected] and make sure to include me [email protected] in the email.

    We can easily move your extension to your publisher, however please note that if there are current extension packs or extension dependencies on your extension they will have to get updated.
    Extension recommendations also need to be updated, but I can easily do that on the VS Code side to take into account the new publisher id.

  14. Ikuyadeu commented on Mar 31, 2022

    @Ikuyadeu
    Member

    Hi VS Code PM here 👋

    I apologise that the Marketplace team did not respond to your request. Can the current extension author please email [email protected] and make sure to include me [email protected] in the email.

    We can easily move your extension to your publisher, however please note that if there are current extension packs or extension dependencies on your extension they will have to get updated. Extension recommendations also need to be updated, but I can easily do that on the VS Code side to take into account the new publisher id.

    Thank you for your response.
    Now, I send the e-mail from [email protected]

  15. renkun-ken commented on May 3, 2022

    @renkun-ken
    MemberAuthor

    Just notice that the publisher id of the extension has been updated:

    https://marketplace.visualstudio.com/items?itemName=REditorSupport.r

    I wonder if there's anything broken on user side?

  16. eitsupi commented on May 3, 2022

    @eitsupi
    Member

    I was wondering why the R extension was not automatically installed when I rebuilt Dev Container last night.
    Definitely an effect of the ID change.

    https://github.com/microsoft/vscode-dev-containers/blob/7a8fa56b33f0477c3f9aed3afdc4e22ace1d606c/containers/r/.devcontainer/devcontainer.json#L29

    In other words, if the ID is specified in settings.json, etc., it would be affected.

  17. eitsupi commented on May 3, 2022

    @eitsupi
    Member

    Perhaps it would be a good idea to announce in the README or elsewhere that the ID has been changed.

  18. renkun-ken commented on May 3, 2022

    @renkun-ken
    MemberAuthor

    Perhaps it would be a good idea to announce in the README or elsewhere that the ID has been changed.

    Yes. I'll include it in the NEWS in the next release.

  19. isidorn commented on May 3, 2022

    @isidorn

    @eitsupi thanks for letting us know. I will update the devcontainer.json today.

  20. eitsupi commented on May 3, 2022

    @eitsupi
    Member

    FYI, after rewriting the ID in devcontainer.json (to reditorsupport.r), it is now installed automatically again.

  21. isidorn commented on May 3, 2022

    @isidorn

    @Ikuyadeu you should also update the publisher in the package.json of your extension to be the new one.

  22. xgdgsc commented on May 11, 2022

    @xgdgsc

    When I click Install in SSH:... in vscode which has a reditorsupport.r installed locally when using remote ssh, it installs ikuyadeu.r.

  23. renkun-ken commented on May 11, 2022

    @renkun-ken
    MemberAuthor

    When I click Install in SSH:... in vscode which has a reditorsupport.r installed locally when using remote ssh, it installs ikuyadeu.r.

    It should work if you uninstall the extension on both local and remote machine, reload vscode, and install again.

  24. xgdgsc commented on May 11, 2022

    @xgdgsc

    No. It doesn' t work for me. I also tried removing .vscode-server/extensions/ikuyadeu.r-2.4.0/ and .vscode-server/. It still would install reditorsupport.r locally and ikuyadeu.r remotely.

    Even I download vsix from https://github.com/REditorSupport/vscode-R/releases/tag/v2.4.0 and use "install with VSIX" menu it would show as
    ikuyadeu.r and the R activity bar icon cannot be shown.

  25. isidorn commented on May 11, 2022

    @isidorn

    The reason for this is that the latest published extension version still has the publisher: ikuyadeu in the package.json.
    @renkun-ken To fix this the extension simply needs to publish a new version (since the publisher is already fixed on the main branch).

  26. renkun-ken commented on May 14, 2022

    @renkun-ken
    MemberAuthor

    A new version is released. @isidorn You could take a look if this still happens.

  27. isidorn commented on May 16, 2022

    @isidorn

    @renkun-ken thanks! @xgdgsc can try it out and let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions