Repository navigation
fix(plot): (re)start jgd server on backend switch - #1766
Merged
Merged
Conversation
The jgd socket server and the JGD_SOCKET terminal env var were only set up at extension activation, and only if r.plot.backend was jgd or auto at that point. Switching the backend to jgd afterwards left R with no renderer connection until VS Code was reloaded. Listen for r.plot.backend changes and start the server (idempotently) and set JGD_SOCKET when the new backend allows jgd, so the change takes effect on the next R restart. Closes #1756
The plot manager now sets JGD_SOCKET via the extension context's environmentVariableCollection during initialization, which the session test's mock context didn't support.
Replace the repeated `backend === 'jgd' || backend === 'auto'` checks with a single helper.
This was referenced Sep 25, 2026
eitsupi
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1756
The
jgdsocket server and theJGD_SOCKETterminal env var were only set up at extension activation, and only ifr.plot.backendwas"jgd"or"auto"at that point. Switching the backend tojgdafterwards left R with no renderer connection until VS Code was reloaded.Fix: Listen for
r.plot.backendchanges and start the server (idempotently) and setJGD_SOCKETwhen the new backend allowsjgd, so the change takes effect on the next R restart.