Conflicting date time accessors with lubridate

A pretty long list of date-time accessors in data.table conflicts with lubridate:

     hour(x)   
     yday(x)   
     wday(x)   
     mday(x)   
     week(x)   
     month(x)  
     quarter(x)
     year(x)

A lot of people, including myself, use both data.table and lubridate routinely. So this overlap is rather an inconvenience. There was even a recent bug report to lubridate as a result of the name collision.

Given that data.table is not dedicated package for working with date-times I wonder if date-time functionality could be split into a separate package or date-time accessors deprecated.

The definitions of these functions in data.table are very basic. In lubridate these are all generics with methods for a variety of classes. Setters are also provided. The default method is the same as it is defined in data.table.

Loading data.table and then lubridate or using :: operator should resolve this? Deprecating it for name clashes seems extreme.

Deprecating it for name clashes seems extreme.

The main proposal was to move IDate into a specialized package. It would make data.table a cleaner package.

+1

@vspinu

@vspinu @zippeurfou
Namespace collision can always happen, what if the next version of other popular package creates a function with overlapping name?

The best way to handle that for production code is to use importFrom in NAMESPACE file in your package.
The most convenient way to handle that for interactive use is to load packages in required order, eventually use :: operator.

You may be also interested in How does R handle overlapping object names?.

Note:

Some unit tests of data.table fail if you do load lubridate after data.table.

IMHO You shouldn't load lubridate if you want to run the
unit tests to verify the correct installation of data.table!

library(lubridate)
library(data.table)
test.data.table()  # runs without errors

If you reset the R session and load data.table first you will get some unit test errors

library(data.table)
library(lubridate)
test.data.table()  # runs with unit test errors

saying e. g.

Running test id 546 Test 546 ran without errors but failed check that x equals y:

@aryoda

Thanks @aryoda. More to do then, including adding tests to test.data.table(with.other.packages=TRUE).

It make sense to attach all exported data.table functions at the beginning of test.data.table(), or eventually detect if exported data.table got masked.

attach functions in case of lubridate/zoo #1135

library(data.table)
library(lubridate)
test.data.table()

Currently passes. Closing.

Navigation Menu

Repository navigation

Conflicting date time accessors with `lubridate` #1135

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Conflicting date time accessors with lubridate #1135

Description

Activity

arunsrinivasan commented on May 4, 2015

vspinu commented on May 4, 2015

zippeurfou commented on Dec 8, 2015

jangorecki commented on Dec 8, 2015

aryoda commented on Apr 3, 2018

mattdowle commented on Apr 22, 2018

jangorecki commented on Mar 12, 2019

MichaelChirico commented on Apr 12, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Conflicting date time accessors with `lubridate` #1135