Integer64 columns not assigned NA when doing a left merge #1459

Activity

1. dlithio commented on Dec 4, 2015

   

   dlithio

   on Dec 4, 2015

   More actions

   I think this is a duplicate.
2. arunsrinivasan commented on Dec 4, 2015

   

   arunsrinivasan

   on Dec 4, 2015

   Member

   More actions

   Thanks for linking to the old issue @dlithio. Maybe we can fix it internally..
3. jangorecki commented on Apr 23, 2016

   

   jangorecki

   on Apr 23, 2016

   Last edited by jangorecki

   Member

   More actions

   The same happens when rbindlist(fill=TRUE). This probably can be fixed in the same place as merge so I'm not creating new issue for that, let me know if you want separate one for rbindlist fill.

   library(data.table)
   library(bit64)
   rbindlist(list(
       data.table(a=1:2, b=as.integer64(c(1,NA))),
       data.table(a=3L)
   ), fill=TRUE)
   #   a                   b
   #1: 1                   1
   #2: 2                  NA
   #3: 3 9218868437227407266
4. arunsrinivasan

   added this to the v1.9.8 milestone on Jul 21, 2016
5. arunsrinivasan

   self-assigned this

   on Jul 21, 2016
6. arunsrinivasan

   added

   enhancement

   on Jul 21, 2016
7. arunsrinivasan

   added a commit that references this issue on Jul 21, 2016

   Closes #1385, partly #1459. Joins handle no match for int64 columns c…

   ...

   7bc0f17
8. arunsrinivasan

   modified the milestones: v2.0.0This milestone has been deleted, v1.9.8 on Jul 25, 2016
9. andrewkho commented on Oct 2, 2017

   

   andrewkho

   on Oct 2, 2017

   Last edited by andrewkho

   More actions

   I'm not sure if I should create a new issue for this, but I am having this problem when using the := operator, but not when using merge.

   > packageVersion("data.table")
   [1] ‘1.10.4’
   > packageVersion("bit64")
   [1] ‘0.9.7’
   > dt1 <- data.table(id=c(1,2), x=bit64::as.integer64(c(100,200)))
   > dt2 <- data.table(id=c(1,3))
   > dt1
      id   x
   1:  1 100
   2:  2 200
   > dt2
      id
   1:  1
   2:  3
   > merge(dt1,dt2, all=T)
      id   x
   1:  1 100
   2:  2 200
   3:  3  NA
   > dt2[J(dt1), x := i.x, on=.(id)]
   > dt2
      id                   x
   1:  1                 100
   2:  3 9218868437227407266
   

   Update: I guess this is the expected behaviour:

   > merge(dt1, dt2, all.y = T)
      id   x
   1:  1 100
   2:  3  NA
   

   I have a lot of code using the := method, and I'm not sure if it's feasible to switch everything to use merge instead
10. MichaelChirico commented on Oct 3, 2017

    

    MichaelChirico

    on Oct 3, 2017 via email

    Member

    More actions

    confirming problem for current dev

    …

    On Tue, Oct 3, 2017 at 5:47 AM, andrewkho ***@***.***> wrote: I'm not sure if I should create a new issue for this, but I am having this problem when using the := operator, but not when using merge. > packageVersion("data.table") [1] ‘1.10.4’ > packageVersion("bit64") [1] ‘0.9.7’ > dt1 <- data.table(id=c(1,2), x=bit64::as.integer64(100,200)) > dt2 <- data.table(id=c(1,3)) > dt1 id x 1: 1 100 2: 2 100 > dt2 id 1: 1 2: 3 > merge(dt1,dt2, all=T) id x 1: 1 100 2: 2 100 3: 3 NA > dt2[J(dt1), x := i.x, on=.(id)] > dt2 id x 1: 1 100 2: 3 9218868437227407266 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1459 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHQQdRNN5xLwJ4C3TIc-jV5zJrfXo4RQks5soVoEgaJpZM4Gul8T> .
11. mattdowle

    removed this from the CandidateThis milestone has been deleted milestone on May 10, 2018
12. jangorecki

    added

    bit64

    on Jan 30, 2019
13. MichaelChirico

    added a commit that references this issue on Jul 23, 2019

    Closes #3723 and #1459 -- use proper NA for integer64 on assign

    d1c9d89
14. mattdowle

    added this to the 1.12.4 milestone on Aug 23, 2019
15. mattdowle

    closed this as completedin #3724on Aug 24, 2019