Skip to content

fread stringsAsFactors=0.2 #2025

Closed
#2545
Closed
fread stringsAsFactors=0.2#2025
#2545
Labels
feature requestfread
Milestone
1.12.4

Description

@mattdowle
mattdowle
opened on Feb 15, 2017

For character columns, if uniqueN(column)/nrow < 0.2 then make the column a factor. Generalizing current binary argument to a scale between FALSE (0.0) and TRUE (1.0).
Request came up for onwards model build which switches based on character / factor type.
No change to default FALSE.

Activity

  1. mattdowle
    added this to the milestone on Feb 15, 2017
  2. mattdowle
    added
    feature request
    on Feb 15, 2017
  3. jangorecki
    added
    fread
    on Mar 5, 2017
  4. mattdowle
    modified the milestones: , on Nov 10, 2017
  5. HughParsonage
    added 3 commits that reference this issue on Jan 16, 2018

    Closes Rdatatable#2025

    a4b6c35

    Update NEWS and documentation for Rdatatable#2025

    ccdf57c

    Merge pull request #3 from HughParsonage/colClasses-valid-type-2545

    6c22aa8
  6. mattdowle
    removed this from the milestone on May 10, 2018
  7. mattdowle
    added this to the 1.12.4 milestone on May 1, 2019
  8. mattdowle
    closed this as completedin #2545on May 2, 2019

  9. MichaelChirico commented on Sep 15, 2020

    @MichaelChirico
    MichaelChirico
    on Sep 15, 2020
    Member

    the closing PR is a bit large, @HughParsonage can you confirm this issue was closed at the R level? I seem to recall it was...

  10. HughParsonage commented on Sep 15, 2020

    @HughParsonage
    HughParsonage
    on Sep 15, 2020
    Member

    Yes:

    data.table/R/fread.R

    Line 322 in be6c1fc

    if (is.double(stringsAsFactors)) { #2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestfread

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions