Skip to content

.. prefix applied to all symbols in j= - #2704

Merged
mattdowle merged 2 commits into
masterfrom
dotdot
Mar 24, 2018
Merged

mattdowle merged 2 commits into
masterfrom
dotdot

Conversation

@mattdowle

Copy link
Copy Markdown
Member

Part satisfies #2655
This should be enough to never need with=
No existing tests changed
Please battle test it. I'll merge to master to make testing easier.

@mattdowle mattdowle added this to the v1.10.6 milestone Mar 24, 2018
@codecov-io

codecov-io commented Mar 24, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #2704 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2704      +/-   ##
==========================================
+ Coverage    93.3%   93.33%   +0.02%     
==========================================
  Files          61       61              
  Lines       12196    12220      +24     
==========================================
+ Hits        11379    11405      +26     
+ Misses        817      815       -2
Impacted Files Coverage Δ
R/data.table.R 97.81% <100%> (+0.02%) ⬆️
src/fsort.c 73.93% <0%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c41a5d...081a605. Read the comment docs.

@mattdowle
mattdowle merged commit f607162 into master Mar 24, 2018
@mattdowle
mattdowle deleted the dotdot branch March 24, 2018 04:01
benmiller314 added a commit to benmiller314/Dissertation-Research that referenced this pull request May 14, 2020
default will still be Title, Pub.number, and tagnames.
NB: using .. notation now as per Rdatatable/data.table#2704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants