Repository navigation
fixed segfault in dev and added check - #3206
Merged
Merged
Conversation
mattdowle
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3206 +/- ##
==========================================
- Coverage 94.57% 94.56% -0.01%
==========================================
Files 61 61
Lines 11739 11741 +2
==========================================
+ Hits 11102 11103 +1
- Misses 637 638 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3206 +/- ##
==========================================
+ Coverage 94.57% 94.57% +<.01%
==========================================
Files 61 61
Lines 11739 11740 +1
==========================================
+ Hits 11102 11103 +1
Misses 637 637
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3204 (segfault in dev starting today).
Thanks @jangorecki for the reprex, and CI pipeline's extra tests for finding it (since Travis and AppVeyor did not).
Merging will see if we pass CI pipeline now. It has a couple of fails, at least one (test-rel-win) was due to this.
(And thanks to me too for leaving in stress-test small batch sizes as a deliberate strategy.)