Skip to content

fread colClasses= fixes - #3273

Merged
mattdowle merged 1 commit into
masterfrom
fread_colClasses
Jan 11, 2019
Merged

mattdowle merged 1 commit into
masterfrom
fread_colClasses

Conversation

@mattdowle

Copy link
Copy Markdown
Member

Closes #2922
Closes #2863

@mattdowle mattdowle added this to the 1.12.0 milestone Jan 11, 2019

@jangorecki jangorecki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Jan 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #3273 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3273      +/-   ##
==========================================
+ Coverage   94.65%   94.68%   +0.02%     
==========================================
  Files          65       65              
  Lines       12109    12109              
==========================================
+ Hits        11462    11465       +3     
+ Misses        647      644       -3
Impacted Files Coverage Δ
src/freadR.c 90.69% <100%> (+0.99%) ⬆️
src/fread.c 98.34% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f726c0...42143d7. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jan 11, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #3273 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3273      +/-   ##
==========================================
+ Coverage   94.65%   94.68%   +0.02%     
==========================================
  Files          65       65              
  Lines       12109    12109              
==========================================
+ Hits        11462    11465       +3     
+ Misses        647      644       -3
Impacted Files Coverage Δ
src/freadR.c 90.69% <100%> (+0.99%) ⬆️
src/fread.c 98.34% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f726c0...42143d7. Read the comment docs.

@mattdowle
mattdowle merged commit 60d7be3 into master Jan 11, 2019
@mattdowle
mattdowle deleted the fread_colClasses branch January 11, 2019 10:49
@mattdowle mattdowle mentioned this pull request Jan 11, 2019
@mattdowle mattdowle mentioned this pull request Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants