Repository navigation
retain PKG_* user-supplied env values - #4735
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4735 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 73 73
Lines 14539 14539
=======================================
Hits 14458 14458
Misses 81 81 Continue to review full report at Codecov.
|
This was referenced Nov 22, 2020
hongyuanjia
pushed a commit
to hongyuanjia/data.table
that referenced
this pull request
Dec 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4664
Aside: I removed the quotes around
"${CC}" "${CFLAGS}"on line 88 because I got an incidental errorgcc -std=gnu99: not foundwhen I was testing. Removing those quotes made that error go away.Shame we can't use
+=inMakevars. It would be nice to know which system'smakedo not support+=, just Solaris? Note that WRE note 70 statesI don't know how SunOS 4 relates to Solaris. And does "elsewhere" mean "everywhere else"? Perhaps WRE is close to allowing
+=.