Repository navigation
cmake: allow explicit version override for tarball builds - #543
Merged
Merged
Conversation
Building from a release tarball has no git metadata, so `git describe` fell back to 0.0.0-unknown — the binary reported the wrong version in the Homebrew, .deb and (future) .rpm packages. Packagers can now pass -DHEADSETCONTROL_VERSION=<version> to set it; git describe is still used when no override is given.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Sapd
added a commit
that referenced
this pull request
Jul 23, 2026
- Resolve .gitattributes (keep both debian/ and headsetcontrol.spec export-ignore) - debian/rules passes -DHEADSETCONTROL_VERSION so future .deb binaries report the real version instead of 0.0.0-unknown (uses #543's CMake override)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release tarballs have no git metadata, so
git describefalls back to0.0.0-unknown— the binary then reports the wrong version in every tarball-based package (Homebrew, the new.deb, and a future.rpm).This adds a
-DHEADSETCONTROL_VERSION=<version>override;git describeis still used when it's not passed (CI, dev builds unchanged).Verified:
-DHEADSETCONTROL_VERSION=9.9.9→HeadsetControl version: 9.9.9HeadsetControl version: 4.0.0-2-ge09264b(git describe)Follow-ups this unblocks (future releases):
inreplacehack, pass-DHEADSETCONTROL_VERSION=#{version}debian/rules: pass it from the changelog version so the .deb binary reports the right version