This repository was archived by the owner on Feb 22, 2020. It is now read-only.
Repository navigation
Throw better exceptions from MemoryAllocators - #25
Merged
Merged
Conversation
dlemstra
reviewed
Apr 20, 2019
dlemstra
left a comment
dlemstra
left a comment
Member
There was a problem hiding this comment.
Good addition. Negative offsets really need a better exception.
JimBobSquarePants
approved these changes
Apr 22, 2019
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
Member
There was a problem hiding this comment.
This is much more helpful!
4 tasks done
antonfirsov
pushed a commit
to SixLabors/ImageSharp
that referenced
this pull request
Jan 19, 2020
…cator-error-handling Throw better exceptions from MemoryAllocators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate arguments for allocation requests, providing a meaningful exception message when
lengthwould result in exceeding the maximum limit for the backingbyte[]inArrayPoolMemoryAlllocator.This should partially address the issues reported in SixLabors/ImageSharp#636.