You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see in #9 that support was added for decoding interlaced PNG images but that support for encoding interlaced images was not considered because it is an uncommon use case.
My question is: if someone (like myself in a fictional world of plentiful free time) were to implement interlaced PNG encoding, would ImageSharp be interested in adopting that feature?
@IldarKhayrutdinov there's no need for such formalities! :)
Feel free to submit a PR, we will review, and most likely accept it (probably after a few change requests).
Hi, I implement interlaced algorithm for pixels, but there are bugs with writing of chunks. Continue working. Unfortunately, there is little time free from the main work.
@IldarKhayrutdinov Thanks! 😄 It's a start which I'm sure we can help with.
If you can open a Work-In-Progress PR against our repo with the check box checked that allows us to push to your PR we should be able to figure this out together.
Activity
JimBobSquarePants commentedon Jun 6, 2017
@atruskie If you implemented it we would be more than happy to accept it! 😄
It's something we would like to have it's just something we have set very low on our priority list.
IldarKhayrutdinov commentedon Jan 3, 2018
@JimBobSquarePants @atruskie If the task is not assigned, please assign it to me.
antonfirsov commentedon Jan 3, 2018
@IldarKhayrutdinov there's no need for such formalities! :)
Feel free to submit a PR, we will review, and most likely accept it (probably after a few change requests).
IldarKhayrutdinov commentedon Jan 3, 2018
@antonfirsov Ok ) I did not want that a few people to do the same task. I will take the task, I think it will take some time.
IldarKhayrutdinov commentedon Jan 23, 2018
Hi, I implement interlaced algorithm for pixels, but there are bugs with writing of chunks. Continue working. Unfortunately, there is little time free from the main work.
JimBobSquarePants commentedon Jan 23, 2018
@IldarKhayrutdinov Thanks! 😄 It's a start which I'm sure we can help with.
If you can open a Work-In-Progress PR against our repo with the check box checked that allows us to push to your PR we should be able to figure this out together.
SixLabors#244 Implement interlaced PNG encoding
SixLabors#244 Implement interlaced PNG encoding
SixLabors#244 Implement interlaced PNG encoding
SixLabors#244 Implement interlaced PNG encoding
SixLabors#244 Update documentations
SixLabors#244 Force rebuild CI
SixLabors#244 Update documentations
SixLabors#244 Remove comment
#244 Add support for interlaced PNG encoding (#955)
JimBobSquarePants commentedon Aug 8, 2019
Fixed with #955
WIP: #12 Synch with master and improve performance of decoders (#986)