Repository navigation
ImageSharp sometimes add gray rectangle at the bottom right #2638
Description
Activity
@br3aker would it be possible for you to have a look at this? I thought we’d fixed it previously.
Reacted by JulienI got the same thing
net8.0
I save it like this:
using var fstream = file.OpenReadStream(); // file is IFormFile (asp.net core) var img = Image.Load(fstream); await img.SaveAsync(filePath, new JpegEncoder { Quality = 50 });cropping the bottom part helps avoid the problem
Does the issue happen on decode or encode?
I got the same thing net8.0
What do you mean by this? Same version different target framework?
@JimBobSquarePants
version 3.1.2
net8.0
the image with the gray square is the result ofimg.SaveAsync(filePath, new JpegEncoder { Quality = 50 });
I assume this is encode.OK. Can you please encode the image as Png and let me know whether the result is the same?
using
await img.SaveAsPngAsync(Path.ChangeExtension(filePath, "png"));I also get the gray square,
I'm also doing a clone and resize to 300x300 and that one also has the square.
Decoder then. Will need to figure out the commit that broke it.
Hm, that's strange. I'll take a look this weekend.
Reacted by James Jackson-SouthThanks @br3aker it was likely something around this. https://github.com/SixLabors/ImageSharp/pull/2516/files#diff-2ffe67fdac3f8753169905e125b8ddb27ec966025580e775f7b07e4c6f2c8d0dR215
Thanks @br3aker it was likely something around this. #2516 (files)
That's actually it but fix is rather complex if we don't want to break existing logic with that fast 'DOS images'. Working on it atm.
Reacted by James Jackson-South@br3aker I kid you not I was JUST this second writing a comment to see if you wanted me to have a look. 🤪
Thanks for helping out. Much appreciated!
This also happens in Version 2.1.6. It's not an Version 3-Issue
This also happens in Version 2.1.6. It's not an Version 3-Issue
I upgraded from 2.1.3 to 2.1.7 due to CVE-2024-27929 and am seeing the gray rectangle on certain images also.
The same code is in both v2 and v3. Trust @br3aker in his analysis, he knows more about that decoder than anyone on the planet.
7 remaining items
Working on it! Just gotta get one critical task done first.
Reacted by Tieson Trowbridge and Paul Seal@JimBobSquarePants - Is there any chance of this being backported to v2? (we're still dependent on .NET Standard) I just tried upgrading to 2.8 from 2.3 (to address the two CVE's) and the gray rectangle appears with our test images. Thank you kindly if you're able to make this happen.
If you open a PR against our 2.1.x release branch I can get one merged. We’re only backporting security releases in-house at the moment to stay on top of maintenance.
If you open a PR against our 2.1.x release branch I can get one merged. We’re only backporting security releases in-house at the moment to stay on top of maintenance.
I appreciate the quick reply and certainly understand you have to prioritize your time. If I knew how to do this I absolutely would do so, I'm just not sure how to even go about attempting something like this unfortunately. Regardless, thank you for everything you do for the community here.
Hi, I got the same issue in my project .net6.0 and the ImageSharp version is 3.1.4.
I couldn't figure out if this issue fixed in 3.1.4 or for next release, anyone help?Hi, I got the same issue in my project .net6.0 and the ImageSharp version is 3.1.4. I couldn't figure out if this issue fixed in 3.1.4 or for next release, anyone help?
The fix has been released. If you are still seeing an issue, please raise a separate ticket with the image in question.
It still does not work with 2.1.9 and .net Framework 4.6.2. Example images here:
2.1.* is unmaintained, only security-critical fixes are being backported.
So this issue will never fixed in 2.1.x? Unfortunately, we cannot use version 3 because we do not (yet) use .net core
If you open a PR against our 2.1.x release branch I can get one merged. We’re only backporting security releases in-house at the moment to stay on top of maintenance.
I have opened a pull request (#2868) that backports this to 2.1.x.
Reacted by Thomas KaegiThe PR was finalized and merged by the maintainers - Thank you for the assistance!
These changes have now been backported and released as part of v2.1.10.
Reacted by Thomas Kaegi
Prerequisites
DEBUGandRELEASEmodeImageSharp version
3.1.0
Other ImageSharp packages and versions
3.0.1
Environment (Operating system, version and so on)
Windows 11
.NET Framework version
.NET 6
Description
On some picture, ImageSharp will add a gray rectangle at the bottom right,
Original:
Final:
Steps to Reproduce
Download sample projet c#
Replace fb.jpg with the original picture:
try it with version 3.0.1, (no gray square)
erease debug + obj and install the latest version 3.1.2 and execute, (gray square)
Images
No response