Change background color when ResizeMode.Pad #466

Activity

1. OscarCanek commented on Feb 15, 2018

   

   OscarCanek

   on Feb 15, 2018

   Author

   More actions

   Solution

   Searching inside the package I found the following extension "BackgroundColor" that meet my needs.

   Example

   newImage.Mutate(x => x
                        .Resize(new SixLabors.ImageSharp.Processing.ResizeOptions
                        {
                            Size = new SixLabors.Primitives.Size(newWidth, newHieght),
                            Mode = SixLabors.ImageSharp.Processing.ResizeMode.Pad                         
                        })
                        .BackgroundColor(new Rgba32(12, 12, 221))
                        );
   

   👍React with 👍8Reacted by James Jackson-South, Stilgar, Matthew D. Groves, dhabierre, Mark Szabo, Aingeru, Charlie and vikas-upadhyay-nps
2. OscarCanek

   closed this as completedon Feb 15, 2018
3. JimBobSquarePants

   added

   question

   on Feb 15, 2018
4. JimBobSquarePants

   reopened this on Mar 19, 2018
5. JimBobSquarePants commented on Mar 19, 2018

   

   JimBobSquarePants

   on Mar 19, 2018

   Last edited by JimBobSquarePants

   Member

   More actions

   Reopening as the solution can be improved upon.

   We should add a parameter to the explicit Pad method to allow a shortcut to setting the color.

   .Mutate(x => x.Pad(int width, int height, TPixel color))

   .Mutate(x => x.Pad(GraphicsOptions options, int width, int height, TPixel color))

   Resize itself will probably stay the same as we don't want to make ResizeOptions a generic type.

   👍React with 👍5Reacted by Stilgar, Mark Szabo, FrogsLegs, Andrey Nikutin and NTDLS

   😄React with 😄1Reacted by Rafael Rivera
6. JimBobSquarePants

   added

   up-for-grabs

   enhancement

   on Mar 21, 2019
7. JimBobSquarePants

   added this to the 1.0.0-rc1 milestone on Mar 21, 2019
8. JimBobSquarePants

   added

   good first issue

   on Mar 21, 2019
9. JimBobSquarePants commented on May 25, 2019

   

   JimBobSquarePants

   on May 25, 2019

   Member

   More actions

   1 year later and I've decided against merging the two methods as it adds internal complexity that I don't think is worth it when you can simply chain commands like above.
10. JimBobSquarePants

    closed this as completedon May 25, 2019
11. JimBobSquarePants

    reopened this on May 25, 2019
12. JimBobSquarePants commented on May 25, 2019

    

    JimBobSquarePants

    on May 25, 2019

    Member

    More actions

    Actually. I'm being an idiot. Gimme 5 minutes.

    😄React with 😄1Reacted by Michael Auerswald
13. JimBobSquarePants

    added a commit that references this issue on May 25, 2019

    Fix #466

    This issue will close once commit d0de176 is merged into the 'main' branch.

    d0de176
14. JimBobSquarePants

    closed this as completedin #916on May 25, 2019
15. JimBobSquarePants

    added a commit that references this issue on May 25, 2019

    Fix #466 (#916)

    This issue will close once commit 32d919e is merged into the 'main' branch.

    32d919e
16. JimBobSquarePants

    added a commit that references this issue on Aug 25, 2019

    WIP: #12 Synch with master and improve performance of decoders (#986)

    ...

    This issue will close once commit 9773e61 is merged into the 'main' branch.

    9773e61