Repository navigation
Separate the tiff encoder classes - #1527
Merged
brianpopow merged 4 commits intoFeb 1, 2021
Merged
Conversation
Closed
17 tasks done
IldarKhayrutdinov
marked this pull request as ready for review
January 31, 2021 14:06
brianpopow
approved these changes
Jan 31, 2021
| /// <param name="memoryAllocator">The memory allocator.</param> | ||
| /// <param name="configuration">The configuration.</param> | ||
| /// <param name="entriesCollector">The entries collector.</param> | ||
| public TiffBaseColorWriter(TiffStreamWriter output, MemoryAllocator memoryAllocator, Configuration configuration, TiffEncoderEntriesCollector entriesCollector) |
Contributor
Author
There was a problem hiding this comment.
sure, done!
|
|
||
| public Stream BaseStream { get; } | ||
|
|
||
| protected MemoryAllocator MemoryAllocator { get; } |
Collaborator
There was a problem hiding this comment.
MemoryAllocator and Configuration below seems not to be used. Can they be removed?
Contributor
Author
There was a problem hiding this comment.
sure, done!
IldarKhayrutdinov
changed the title
4 tasks done
JimBobSquarePants
pushed a commit
that referenced
this pull request
Feb 17, 2021
Separate the tiff encoder classes
JimBobSquarePants
pushed a commit
that referenced
this pull request
Feb 17, 2021
Separate the tiff encoder classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
TiffWriterclass.Only splitting and moving classes, no change algorithms.