Repository navigation
Adds support for OS/2 version 2 bitmaps - #813
Conversation
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
==========================================
- Coverage 88.75% 88.74% -0.01%
==========================================
Files 1014 1014
Lines 44048 44079 +31
Branches 3175 3178 +3
==========================================
+ Hits 39093 39117 +24
- Misses 4229 4234 +5
- Partials 726 728 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
==========================================
- Coverage 88.75% 88.73% -0.02%
==========================================
Files 1014 1015 +1
Lines 44048 44081 +33
Branches 3175 3178 +3
==========================================
+ Hits 39093 39117 +24
- Misses 4229 4236 +7
- Partials 726 728 +2
Continue to review full report at Codecov.
|
|
@brianpopow Those new exceptions are going to start to hurt performance and coverage. Would it be possible for you to refactor them out into a static BmpThrowHelper class like the ThrowHelper class in the jpeg decoder? |
|
Merged. Thanks again, couldn't do this without you! |
* Added support for OS/2 version 2 bitmaps * throw NotSupportedException, if the file header type is not BM * renamed Os2v2 to Os2v2Size * Added BmpThrowHelper similar to the JpegThrowHelper
2 participants
Prerequisites
Description
This PR adds support for decoding OS/2 version 2 bitmaps (at least partially). OS/2 v2 introduces additional compression type of RLE24 and 1D Huffman, which is not supported.
I had some trouble finding actual example images for this. I have only one with no compression. RLE4 and RLE8 should work, too, but i could not find those.