Skip to content

#852 Adding instructions to add submodules when cloning the repository - #853

Merged
antonfirsov merged 2 commits into
SixLabors:masterfrom
bulldetektor:fix/update_readme_with_git_submodules
Mar 21, 2019
Merged

#852 Adding instructions to add submodules when cloning the repository#853
antonfirsov merged 2 commits into
SixLabors:masterfrom
bulldetektor:fix/update_readme_with_git_submodules

Conversation

@bulldetektor

@bulldetektor bulldetektor commented Mar 21, 2019

Copy link
Copy Markdown
Contributor

Fixes #852

@CLAassistant

CLAassistant commented Mar 21, 2019 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Mar 21, 2019
JimBobSquarePants
JimBobSquarePants approved these changes Mar 21, 2019
View reviewed changes

@JimBobSquarePants JimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated!

@codecov

codecov Bot commented Mar 21, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #853 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
- Coverage   88.89%   88.79%   -0.11%     
==========================================
  Files        1014     1014              
  Lines       44295    44295              
  Branches     3208     3208              
==========================================
- Hits        39376    39331      -45     
- Misses       4198     4203       +5     
- Partials      721      761      +40
Impacted Files Coverage Δ
...xelFormats/PixelOperations{TPixel}.PixelBenders.cs 89.34% <0%> (-9.84%) ⬇️
...Processing/Processors/Transforms/TransformUtils.cs 88.29% <0%> (-5.32%) ⬇️
src/ImageSharp/Common/Helpers/ImageMaths.cs 82.05% <0%> (-5.13%) ⬇️
.../Processing/Processors/Transforms/CropProcessor.cs 96% <0%> (-4%) ⬇️
...ocessing/Processors/Dithering/ErrorDiffuserBase.cs 93.75% <0%> (-3.13%) ⬇️
...rs/Normalization/HistogramEqualizationProcessor.cs 97.5% <0%> (-2.5%) ⬇️
...ormats/Jpeg/Components/Decoder/QualityEvaluator.cs 94.04% <0%> (-2.39%) ⬇️
...eSharp.Tests/IO/DoubleBufferedStreamReaderTests.cs 97.61% <0%> (-2.39%) ⬇️
.../ImageSharp.Tests/TestUtilities/TestEnvironment.cs 79.16% <0%> (-2.09%) ⬇️
...p/Formats/Jpeg/Components/Decoder/JpegComponent.cs 94.11% <0%> (-1.97%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7670728...e780d60. Read the comment docs.

@antonfirsov
antonfirsov merged commit 47e8f2c into SixLabors:master Mar 21, 2019
antonfirsov added a commit to antonfirsov/ImageSharp that referenced this pull request Nov 11, 2019
@antonfirsov
Merge pull request SixLabors#853 from bulldetektor/fix/update_readme_…
acb5766 
…with_git_submodules

SixLabors#852 Adding instructions to add submodules when cloning the repository
This was referenced Jul 30, 2025
Merged
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 3, 2025
Open
Merged
Closed
This was referenced Mar 1, 2026
Open
Open
@dependabot dependabot Bot mentioned this pull request Apr 26, 2026
Merged
@dependabot dependabot Bot mentioned this pull request Aug 2, 2026
Open
@dependabot dependabot Bot mentioned this pull request Aug 16, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tocsoft tocsoft tocsoft approved these changes
@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

1.0.0-rc1

Development

Successfully merging this pull request may close these issues.

5 participants

@bulldetektor @CLAassistant @tocsoft @JimBobSquarePants @antonfirsov