You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
JCEF has no CefFrameHandler binding (no frame create/destroy/attach lifecycle events) #34
org.cef.browser.CefFrame objects exist, but there's no Java equivalent of CEF's CefFrameHandler -- no way to observe frame lifecycle events (OnFrameCreated, OnFrameDestroyed, OnFrameAttached, OnFrameDetached, OnMainFrameChanged, include/cef_frame_handler.h). Callers can only discover frames reactively (e.g. from CefLoadHandler), with no signal for iframe creation/teardown or cross-origin main-frame changes.
grep-confirmed before this fix: no frame_handler.cpp/CefFrameHandler anywhere in native/ or java/org/cef/handler/.
Fix
Implemented in commit 17ba666 on branch coverage/phase1-value-objects-phase2-handlers:
Covered by CefFrameHandlerCoverageTest (java/tests/junittests/): a data: URL iframe deterministically exercises onFrameCreated/onFrameAttached for a real sub-frame without needing extra test-harness plumbing. Verified passing in isolation.
Summary
org.cef.browser.CefFrameobjects exist, but there's no Java equivalent of CEF'sCefFrameHandler-- no way to observe frame lifecycle events (OnFrameCreated,OnFrameDestroyed,OnFrameAttached,OnFrameDetached,OnMainFrameChanged,include/cef_frame_handler.h). Callers can only discover frames reactively (e.g. fromCefLoadHandler), with no signal for iframe creation/teardown or cross-origin main-frame changes.grep-confirmed before this fix: noframe_handler.cpp/CefFrameHandleranywhere innative/orjava/org/cef/handler/.Fix
Implemented in commit 17ba666 on branch
coverage/phase1-value-objects-phase2-handlers:native/frame_handler.{h,cpp}+org.cef.handler.CefFrameHandler(+CefFrameHandlerAdapter), wired intoclient_handler.cpp/CefClientthe same way every other handler type is (following theCefFindHandler/find_handler.cpppattern from the prior JCEF has no CefFindHandler binding (no onFindResult) -- find()/stopFinding() are fire-and-forget #32 fix).CefFrameHandlerCoverageTest(java/tests/junittests/): adata:URL iframe deterministically exercisesonFrameCreated/onFrameAttachedfor a real sub-frame without needing extra test-harness plumbing. Verified passing in isolation.🤖 Generated with Claude Code