Repository navigation
Fix issue #13: CefQueryCallback.success() ignores persistent=true - #38
Merged
Merged
Conversation
This was referenced Sep 5, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
============================================
+ Coverage 38.01% 38.99% +0.98%
- Complexity 735 746 +11
============================================
Files 243 244 +1
Lines 14863 14904 +41
Branches 2449 2454 +5
============================================
+ Hits 5650 5812 +162
+ Misses 8011 7870 -141
- Partials 1202 1222 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 of 2 tasks
Thrameos
added a commit
that referenced
this pull request
Sep 5, 2026
preliminary update racing ahead of onBeforeDownload CefDownloadItemTest.cancelDuringDownloadInvokesNCancel() flaked intermittently in CI across multiple unrelated backport PRs (#38, #39, #41, #42), always failing the same assertion: "onBeforeDownload was never invoked". Root-caused by reproducing it locally (100% deterministic once a low-risk, narrowly-scoped repro was possible -- see PR #44's run_tests.sh fix, needed first to run just this one test without also running the whole suite + leak-sweep) and adding temporary native fprintf instrumentation (not included in this commit) at DownloadHandler::OnBeforeDownload/ OnDownloadUpdated and ClientHandler::GetDownloadHandler. That instrumentation showed CEF can deliver a preliminary OnDownloadUpdated() notification -- for a valid, real CefDownloadItem -- *before* OnBeforeDownload() has been dispatched to the handler at all. This test's onDownloadUpdated() used to treat "not complete" on the very first update it saw as "must actively cancel it", immediately calling callback.cancel() and terminateTest() -- racing ahead of onBeforeDownload and ending the test before it ever got a chance to run, which is exactly what "onBeforeDownload was never invoked" captures. Fix: ignore any onDownloadUpdated() notification that arrives before this handler's own onBeforeDownload() has recorded its decision (gotBeforeDownload[0]). Verified via direct reproduction: failed 3/3 in isolation before the fix (including against a heavily-used local CEF profile where it failed 100% of the time), passed cleanly every time after (5+ consecutive solo runs, plus the full class together) with no change to downloadCompletesAndWritesRealFile's behavior. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HBFmQs6JDypYP5qdC99yDq
N_Success unconditionally cleared the native reference after the first call, regardless of whether the originating query was persistent, so a second success() call on the same callback silently no-op'd. Thread the persistent flag (already known to MessageRouterHandler::OnQuery()) through to CefQueryCallback_N via a new setPersistent() call made right after the callback object is constructed, and only clear the native ref in N_Success when the query is not persistent. N_Failure is unchanged -- a failure always ends the query. Adds UpstreamIssue398Test (matches upstream chromiumembedded#398) as a regression test, ported from the future branch's own repro. Verified against a full local suite run: 124/124 passing. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HBFmQs6JDypYP5qdC99yDq
Thrameos
force-pushed
the
backport/query-callback-persistent
branch
from
September 5, 2026 21:23
72d9263 to
409fa1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13 (matches upstream chromiumembedded#398)
Summary
persistent: true) is documented to allowCefQueryCallback.success()to be called repeatedly, with each call invoking the JSonSuccesshandler again.native/CefQueryCallback_N.cpp'sN_Successunconditionally cleared the native reference after the first call regardless ofpersistent, so a secondsuccess()call on the same callback silently no-op'd.persistentflag (already known toMessageRouterHandler::OnQuery()) through toCefQueryCallback_Nvia a newsetPersistent()call made right after the callback object is constructed, and only clearing the native ref inN_Successwhen the query is not persistent.N_Failureis unchanged -- a failure always ends the query.Test plan
UpstreamIssue398Test(matches upstreamchromiumembedded/java-cef#398) as a regression test.libjcef.socleanly (ninja jcef), zero compile errors.Small, focused backport of a single self-contained fix (no other changes bundled in), following the same shape as PR #1, #36, and #37.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HBFmQs6JDypYP5qdC99yDq