Fix crash on redo after collated control point / vertex drags - #5392
Merged
Merged
Conversation
A single drag produces one NodeHandleCommand per mouse-move event, and the command processor collates them into just the first one. That command's recorded target handle positions were never updated to the drag's actual endpoint, so reselecting them on redo could look up a handle that no longer exists and crash (#5379). doCollateWith now adopts the collated-away command's target positions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single drag produces one NodeHandleCommand per mouse-move event, and the command processor collates them into just the first one. That command's recorded target handle positions were never updated to the drag's actual endpoint, so reselecting them on redo could look up a handle that no longer exists and crash (#5379).
In addition to fixing the crash, we add more test coverage for ControlPointTool.
Closes #5379.