This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Repository navigation
Avoid a duplicate query for the comment count - #2015
Merged
Merged
Conversation
Member
Author
|
This was introduced originally in #1209, since (as the failing test shows) out-of-bounds pages will give back 0 for Changed this to using the normal query on in-bounds requests, and only running the secondary query if we're out of bounds. Updating other controllers now. |
Member
Author
|
@WP-API/amigos #reviewmerge |
Member
|
Looks good 👍 And well-covered by existing tests. |
danielbachhuber
added a commit
that referenced
this pull request
Jan 13, 2016
Avoid a duplicate query for the comment count
Member
|
Related:
Although, in this case, I think this PR is still better than what we had before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back in 768a282 (#1197), we introduced the regular pagination headers for comment queries. However, apparently we missed that
WP_Comment_QueryhasSQL_CALC_FOUND_ROWSbuilt-in (but off by default), so we're doing a complex query twice here.Attached patch uses
$query->found_commentsand$query->max_num_pagesinstead of redoing the query.