Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Fields cleanup for User controller - #701

Merged
joehoyle merged 4 commits into
developfrom
605-user-fields
Dec 9, 2014
Merged

joehoyle merged 4 commits into
developfrom
605-user-fields

Conversation

@danielbachhuber

Copy link
Copy Markdown
Member
  • Only expose username in edit context.
  • Rename registered to registered_date, and only expose in view context.
  • Rename avatar to avatar_url.
  • Some test coverage to address potential data leakage.

See #605

@danielbachhuber danielbachhuber added this to the 2.0 milestone Dec 9, 2014
@danielbachhuber

Copy link
Copy Markdown
Member Author

@WP-API/amigos #reviewmerge

@joehoyle

joehoyle commented Dec 9, 2014

Copy link
Copy Markdown
Member

Looks goood to me

joehoyle added a commit that referenced this pull request Dec 9, 2014
Fields cleanup for User controller
@joehoyle
joehoyle merged commit ec59ef9 into develop Dec 9, 2014
@joehoyle
joehoyle deleted the 605-user-fields branch December 9, 2014 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants