Skip to content

Implement table.fill - #5949

Merged
tlively merged 2 commits into
mainfrom
table-fill
Sep 18, 2023
Merged

tlively merged 2 commits into
mainfrom
table-fill

Conversation

@tlively

@tlively tlively commented Sep 16, 2023

Copy link
Copy Markdown
Member

This instruction was standardized as part of the bulk memory proposal, but we
never implemented it until now. Leave similar instructions like table.copy as
future work.

Fixes #5939.

This instruction was standardized as part of the bulk memory proposal, but we
never implemented it until now. Leave similar instructions like table.copy as
future work.

Fixes #5939.
@tlively
tlively requested a review from kripken September 16, 2023 02:19
@tlively

tlively commented Sep 16, 2023

Copy link
Copy Markdown
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov

codecov Bot commented Sep 16, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #5949 (05e75b3) into main (6dde22c) will increase coverage by 0.00%.
Report is 4 commits behind head on main.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #5949   +/-   ##
=======================================
  Coverage   42.80%   42.80%           
=======================================
  Files         485      485           
  Lines       74943    75008   +65     
  Branches    11958    11963    +5     
=======================================
+ Hits        32076    32105   +29     
- Misses      39665    39698   +33     
- Partials     3202     3205    +3     
Files Changed Coverage Δ
src/ir/ReFinalize.cpp 76.05% <0.00%> (-0.54%) ⬇️
src/ir/cost.h 37.28% <0.00%> (-0.33%) ⬇️
src/ir/effects.h 49.01% <0.00%> (-0.33%) ⬇️
src/ir/possible-contents.cpp 85.97% <0.00%> (-0.12%) ⬇️
src/wasm-binary.h 84.29% <ø> (ø)
src/wasm-delegations-fields.def 27.58% <0.00%> (-0.33%) ⬇️
src/wasm-interpreter.h 20.15% <0.00%> (-0.18%) ⬇️
src/wasm-ir-builder.h 100.00% <ø> (ø)
src/wasm-s-parser.h 92.30% <ø> (ø)
src/wasm.h 58.33% <ø> (ø)
... and 11 more

... and 4 files with indirect coverage changes

@tlively
tlively enabled auto-merge (squash) September 18, 2023 19:24
@tlively
tlively merged commit 003a6ff into main Sep 18, 2023
@tlively
tlively deleted the table-fill branch September 18, 2023 19:42
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
This instruction was standardized as part of the bulk memory proposal, but we
never implemented it until now. Leave similar instructions like table.copy as
future work.

Fixes WebAssembly#5939.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wasm-opt missing support for table.fill

2 participants