Repository navigation
Error on multivalue inputs that we do not handle - #5962
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5962 +/- ##
==========================================
- Coverage 42.84% 42.84% -0.01%
==========================================
Files 492 492
Lines 75033 75037 +4
Branches 11974 11976 +2
==========================================
Hits 32147 32147
- Misses 39680 39681 +1
- Partials 3206 3209 +3
|
tlively
approved these changes
Sep 19, 2023
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Before in getType() we silently dropped the params of a signature type. Now we verify that it is none, or we error. Helps WebAssembly#5950
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before in
getType()we silently dropped the params of a signature type. Now we verify thatit is
none, or we error.Helps #5950