Fixes issue with incorrect urls in signup and activation flow for mul… by hasukmistry · Pull Request #12257 · WordPress/wordpress-develop

hasukmistry · 2026-06-22T07:20:53Z

Trac ticket: https://core.trac.wordpress.org/ticket/65506

github-actions · 2026-06-22T07:21:02Z

Hi there! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

github-actions · 2026-06-22T07:21:05Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props meet_hasmukh, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-06-22T07:25:04Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

…tisite environment

… wp-activate.php and wp-signup.php Co-authored-by: Weston Ruter <[email protected]>

westonruter

LGTM

…lines

…ignup()

westonruter · 2026-07-07T02:42:59Z

 					esc_url( wp_lostpassword_url() )
 				);
 			} else {
+				$url = ( is_ssl() ? 'https://' : 'http://' ) . $signup->domain . $blog_details->path;


When analyzing at the changes in this PR with PHPStan, I found 3 errors:

156 Binary operation "." between 'http://'|'https://' and mixed results in an error. 🪪 binaryOp.invalid 156 Cannot access property $domain on mixed. 🪪 property.nonObject 156 Cannot access property $path on WP_Site|null. 🪪 property.nonObject

These are not introduced by this PR, but in the interest of cleaning such issues up as we go, I've added a couple commits to this PR to address type issues with the related code.

When an already-active signup is revisited, `wp-activate.php` hard-coded the `http://` scheme and passed the scheme-less domain and path through `esc_url()`, which prepended its own `http://` and produced a doubled, broken `http://http://` link. Build the full URL with the correct scheme from `is_ssl()` before escaping it. Additionally, the signup confirmation heading in `wp-signup.php` now uses a scheme-relative `//` URL so the link honors the network's HTTPS configuration instead of forcing `http`. This also hardens related code in `wp-activate.php` and `wpmu_activate_signup()` against type issues surfaced by PHPStan, including normalizing the signup meta to always be an array. Developed in #12257. Follow-up to r12603, r48672, r57625. Props meet_hasmukh, westonruter. See #64898. Fixes #65506. git-svn-id: https://develop.svn.wordpress.org/trunk@62651 602fd350-edb4-49c9-b593-d223f7449a82

github-actions · 2026-07-07T03:06:16Z

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62651
GitHub commit: c236f38

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

When an already-active signup is revisited, `wp-activate.php` hard-coded the `http://` scheme and passed the scheme-less domain and path through `esc_url()`, which prepended its own `http://` and produced a doubled, broken `http://http://` link. Build the full URL with the correct scheme from `is_ssl()` before escaping it. Additionally, the signup confirmation heading in `wp-signup.php` now uses a scheme-relative `//` URL so the link honors the network's HTTPS configuration instead of forcing `http`. This also hardens related code in `wp-activate.php` and `wpmu_activate_signup()` against type issues surfaced by PHPStan, including normalizing the signup meta to always be an array. Developed in WordPress/wordpress-develop#12257. Follow-up to r12603, r48672, r57625. Props meet_hasmukh, westonruter. See #64898. Fixes #65506. Built from https://develop.svn.wordpress.org/trunk@62651 git-svn-id: http://core.svn.wordpress.org/trunk@61936 1a063a9b-81f0-0310-95a4-ce76da25c4cd

westonruter reviewed Jun 29, 2026

View reviewed changes

Comment thread src/wp-activate.php Outdated

westonruter reviewed Jun 29, 2026

View reviewed changes

Comment thread src/wp-signup.php Outdated

hasukmistry force-pushed the ticket-65506 branch from f5f619f to 8f05b2c Compare June 30, 2026 02:08

hasukmistry and others added 2 commits June 30, 2026 07:59

Fixes issue with incorrect urls in signup and activation flow for mul…

1c59dbd

…tisite environment

Simplifies url buiilding, clean up and applies scheme-relative URL in…

5406b49

… wp-activate.php and wp-signup.php Co-authored-by: Weston Ruter <[email protected]>

hasukmistry force-pushed the ticket-65506 branch from 8f05b2c to 5406b49 Compare June 30, 2026 02:29

hasukmistry requested a review from westonruter June 30, 2026 02:48

westonruter approved these changes Jul 1, 2026

View reviewed changes

pento force-pushed the trunk branch from 3af2d27 to 64ede28 Compare July 6, 2026 03:10

westonruter added 3 commits July 6, 2026 18:08

Merge branch 'trunk' into ticket-65506

18873af

Add type definitions for variables to fix static analysis on changed …

5ea677b

…lines

Address related PHPStan errors in wp-activate.php and wpmu_activate_s…

025a271

…ignup()

westonruter reviewed Jul 7, 2026

View reviewed changes

Remove description from var

6bc3caf

github-actions Bot closed this Jul 7, 2026

Navigation Menu

Repository navigation

Fixes issue with incorrect urls in signup and activation flow for mul… - #12257

Fixes issue with incorrect urls in signup and activation flow for mul…#12257
hasukmistry wants to merge 6 commits into
WordPress:trunkfrom
hasukmistry:ticket-65506

hasukmistry commented Jun 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

Uh oh!

Uh oh!

westonruter left a comment

Uh oh!

westonruter Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hasukmistry commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

Uh oh!

Uh oh!

westonruter left a comment

Choose a reason for hiding this comment

Uh oh!

westonruter Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hasukmistry commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading