Repository navigation
Make bounded source summaries fair across providers - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue discovered by the v0.7 live smoke: a global
--max-resultsbudget in--source-summarycould be exhausted by the first provider before later providers were queried.New behavior
For bounded source summaries, the same run-wide cap is now applied independently to each selected archive source. This preserves a bounded sample from every provider while still marking the summary incomplete.
Unlimited source summaries keep the existing single multi-source collection path, so there is no extra overhead when
--max-results 0is used.Coverage
Part of #13.