Skip to content

fix(router): child CanActivate guard should wait for parent to complete - #18110

Closed
jasonaden wants to merge 1 commit into
angular:masterfrom
jasonaden:fix_can_activate_wait
Closed

fix(router): child CanActivate guard should wait for parent to complete#18110
jasonaden wants to merge 1 commit into
angular:masterfrom
jasonaden:fix_can_activate_wait

Conversation

@jasonaden

@jasonaden jasonaden commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

Closes #15670

@googlebot

googlebot commented Jul 13, 2017

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@jasonaden

jasonaden commented Jul 13, 2017

Copy link
Copy Markdown
Contributor Author

@nrgonzalez777 You had previously commented that you have a use case where this doesn't work (see #15672). Are you able to articulate more? I know it's been a bit, but I'm going back through some of these older PRs to try to get the addressed and the behavior in this PR seems to be what we would want.

Thanks!

@jasonaden jasonaden added area: router action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 19, 2017
vicb
vicb reviewed Jul 19, 2017
View reviewed changes
Comment thread packages/router/test/integration.spec.ts Outdated

@vicb vicb Jul 19, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be resolve(boolean) if Promise<boolean>

vicb
vicb suggested changes Jul 19, 2017
View reviewed changes

@vicb vicb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comment

@mhevery
mhevery force-pushed the fix_can_activate_wait branch from 717822a to e55a859 Compare July 26, 2017 17:13
@jasonaden
jasonaden force-pushed the fix_can_activate_wait branch from e55a859 to f5d9f77 Compare July 26, 2017 17:18
@vicb vicb removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 26, 2017
@jasonaden jasonaden added action: merge The PR is ready for merge by the caretaker and removed cla: no labels Jul 26, 2017
@mary-poppins

mary-poppins commented Jul 26, 2017

Copy link
Copy Markdown

You can preview f5d9f77 at https://pr18110-f5d9f77.ngbuilds.io/.

@mhevery mhevery added the target: patch This PR is targeted for the next patch release label Jul 26, 2017
@mhevery mhevery closed this in 086f4aa Jul 26, 2017
mhevery pushed a commit that referenced this pull request Jul 26, 2017
@mhevery
fix(router): child CanActivate guard should wait for parent to comple…
b9e32c8 
…te (#18110)

Closes #15670

PR Close #18110
mhevery added a commit to mhevery/angular that referenced this pull request Jul 27, 2017
@mhevery
Revert "fix(router): child CanActivate guard should wait for parent t…
c17ba61 
…o complete (angular#18110)"

This reverts commit 086f4aa.
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@DzmitryShylovich Zhicheng Wang
fix(router): child CanActivate guard should wait for parent to comple…
49a7513 
…te (angular#18110)

Closes angular#15670

PR Close angular#18110
@albv albv mentioned this pull request Aug 17, 2017
Open
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
@DzmitryShylovich @juleskremer
fix(router): child CanActivate guard should wait for parent to comple…
0e6622e 
…te (angular#18110)

Closes angular#15670

PR Close angular#18110
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@DzmitryShylovich @juleskremer
fix(router): child CanActivate guard should wait for parent to comple…
50376d4 
…te (angular#18110)

Closes angular#15670

PR Close angular#18110
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@vicb vicb vicb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: router target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CanActivate guards on child routes run before parent CanActivate guards finish

6 participants

@jasonaden @googlebot @mary-poppins @vicb @mhevery @DzmitryShylovich