Repository navigation
Conversation
atscott
added
area: router
target: patch
atscott
force-pushed
the
additionalinitialnavtests
branch
from
May 2, 2022 16:04
df89d9e to
fb9703e
Compare
atscott
force-pushed
the
additionalinitialnavtests
branch
2 times, most recently
from
May 3, 2022 22:49
346ed10 to
8c06d9d
Compare
atscott
force-pushed
the
additionalinitialnavtests
branch
from
May 17, 2022 20:31
8c06d9d to
0f90237
Compare
AndrewKushnir
approved these changes
May 17, 2022
atscott
force-pushed
the
additionalinitialnavtests
branch
from
May 17, 2022 20:48
0f90237 to
ebe14d9
Compare
Adds additional tests to verify `enabledBlocking` functionality. The initial attempt to fix angular#44355 would have broken the scenario where a new navigation cancels the initial navigation. We also cannot rely on `NavigationError` like the example workaround in that issue report is doing because there won't be one if a guard simply rejects the initial nav (angular#16211).
atscott
force-pushed
the
additionalinitialnavtests
branch
from
May 17, 2022 20:49
ebe14d9 to
44a91f1
Compare
jessicajaniuk
added
target: rc
Contributor
|
There are merge issues with |
Contributor
|
This PR was merged into the repository by commit e92799c. |
jessicajaniuk
pushed a commit
that referenced
this pull request
May 18, 2022
Adds additional tests to verify `enabledBlocking` functionality. The initial attempt to fix #44355 would have broken the scenario where a new navigation cancels the initial navigation. We also cannot rely on `NavigationError` like the example workaround in that issue report is doing because there won't be one if a guard simply rejects the initial nav (#16211). PR Close #45733
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds additional tests to verify
enabledBlockingfunctionality. Theinitial attempt to fix #44355 would have broken the scenario where a new
navigation cancels the initial navigation. We also cannot rely on
NavigationErrorlike the example workaround in that issue report isdoing because there won't be one if a guard simply rejects
the initial nav (#16211).